Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm
index 548b2a0bc0d0439cde139b9436f470f467be5d85..2430d32f17fb22f2104c8913a086befda8409732 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm
@@ -12,6 +12,7 @@
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
@@ -45,7 +46,8 @@ class AsyncUninstaller : public extensions::ExtensionUninstallDialog::Delegate {
       : extension_(extension),
         profile_(browser->profile()) {
     extension_uninstall_dialog_.reset(
-        extensions::ExtensionUninstallDialog::Create(profile_, browser, this));
+        extensions::ExtensionUninstallDialog::Create(
+            profile_, chrome::FindWindowForBrowser(browser), this));

[sashab, 2014/07/23 23:57:26]

tapted: Seeing as how Mac doesn't even need the parent window, and this is a
Mac-only file, is it even worth passing this? I guess that's an implementation
abstraction that may change in the future.

[tapted, 2014/07/24 00:35:36]

I'm inclined to keep it, just because it's jumping through so many API
boundaries. Also, it could for example try to pick a more correct display to pop
up the dialog (NSAlert tries to pick the display "in use" by the user, which is
usually right). But hopefully this entire file will disappear in a milestone or
three when we have toolkit-views on Mac.

     extension_uninstall_dialog_->ConfirmUninstall(extension_);
   }