Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm

Index: chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm b/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
index ca9cf2210a25330c86e85409d4e2f353080649e2..f0a949870b24305a4b73cb9cbfe7dc123c3087db 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
@@ -27,21 +27,21 @@ namespace {
 class ExtensionUninstallDialogCocoa
     : public extensions::ExtensionUninstallDialog {
  public:
-  ExtensionUninstallDialogCocoa(
-      Profile* profile,
-      Browser* browser,
-      Delegate* delegate);
+  ExtensionUninstallDialogCocoa(Profile* profile,
+                                gfx::NativeWindow parent,
+                                Delegate* delegate);
   virtual ~ExtensionUninstallDialogCocoa() OVERRIDE;
 
  private:
   virtual void Show() OVERRIDE;
+  virtual void RefreshIcon() OVERRIDE;
 };
 
 ExtensionUninstallDialogCocoa::ExtensionUninstallDialogCocoa(
     Profile* profile,
-    Browser* browser,
+    gfx::NativeWindow parent,
     extensions::ExtensionUninstallDialog::Delegate* delegate)
-    : extensions::ExtensionUninstallDialog(profile, browser, delegate) {
+    : extensions::ExtensionUninstallDialog(profile, parent, delegate) {
 }
 
 ExtensionUninstallDialogCocoa::~ExtensionUninstallDialogCocoa() {}
@@ -69,12 +69,16 @@ void ExtensionUninstallDialogCocoa::Show() {
     delegate_->ExtensionUninstallCanceled();
 }
 
+void ExtensionUninstallDialogCocoa::RefreshIcon() {
+  // TODO: Refresh the icon in Cocoa somehow

[sashab, 2014/07/23 23:57:26]

tapted: Is this possible?

[tapted, 2014/07/24 00:35:36]

Sadly not :/ - we don't have much control over `NSAlert`, and it's run
application modally so no way* to react to the icon loaded callback while it's
shown. (This might answer sky's question). Although I'm pretty sure all the
_install_ (and permissions) dialogs simply delay showing themselves until the
ImageLoader triggers its OnImageLoaded callback as well.

But for an install it's much more likely that the icon is not ready: for an
_uninstall_ it would be uncommon for an icon to require loading - app launcher
would almost certainly have loaded it already, but extensions can also be
uninstalled from the toolbar action button via right-click. In this case, a null
icon is more probable in this case.


*no way = Cocoa has some threading support - there's a chance altering the
underlying NSImage in a background thread does the right thing, but there be
dragons. Many dragons.

+}
+
 }  // namespace
 
 // static
 extensions::ExtensionUninstallDialog*
 extensions::ExtensionUninstallDialog::Create(Profile* profile,
-                                             Browser* browser,
+                                             gfx::NativeWindow parent,
                                              Delegate* delegate) {
-  return new ExtensionUninstallDialogCocoa(profile, browser, delegate);
+  return new ExtensionUninstallDialogCocoa(profile, parent, delegate);
 }