Refactored ExtensionUninstallDialog to take a NativeWindow instead of a Browser

chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
 #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 #include "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/manifest_url_handler.h"
 #include "chrome/common/pref_names.h"
@@ skipping 13 matching lines @@
 using extensions::Extension;
 
 // A class that shows a confirmation dialog to uninstall the given extension.
 // Also acts as the extension's UI delegate in order to display the dialog.
 class AsyncUninstaller : public extensions::ExtensionUninstallDialog::Delegate {
  public:
   AsyncUninstaller(const Extension* extension, Browser* browser)
       : extension_(extension),
         profile_(browser->profile()) {
     extension_uninstall_dialog_.reset(
-        extensions::ExtensionUninstallDialog::Create(profile_, browser, this));
+        extensions::ExtensionUninstallDialog::Create(
+            profile_, chrome::FindWindowForBrowser(browser), this));

[sashab, 2014/07/23 23:57:26]

tapted: Seeing as how Mac doesn't even need the parent window, and this is a
Mac-only file, is it even worth passing this? I guess that's an implementation
abstraction that may change in the future.

[tapted, 2014/07/24 00:35:36]

I'm inclined to keep it, just because it's jumping through so many API
boundaries. Also, it could for example try to pick a more correct display to pop
up the dialog (NSAlert tries to pick the display "in use" by the user, which is
usually right). But hopefully this entire file will disappear in a milestone or
three when we have toolkit-views on Mac.

     extension_uninstall_dialog_->ConfirmUninstall(extension_);
   }
 
   virtual ~AsyncUninstaller() {}
 
   // ExtensionUninstallDialog::Delegate:
   virtual void ExtensionUninstallAccepted() OVERRIDE {
     extensions::ExtensionSystem::Get(profile_)
         ->extension_service()
         ->UninstallExtension(extension_->id(),
@@ skipping 163 matching lines @@
     return;
 
   [ExtensionPopupController showURL:url
                           inBrowser:browser_
                          anchoredAt:popupPoint
                       arrowLocation:info_bubble::kTopRight
                             devMode:YES];
 }
 
 @end