Issue 382053004: Adds API test for imageWriterPrivate.writeFromFile

Issue 382053004: Adds API test for imageWriterPrivate.writeFromFile (Closed)

Created:
6 years, 5 months ago by Drew Haven

Modified:
6 years, 5 months ago

Reviewers:
dgrogan

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Adds API test for imageWriterPrivate.writeFromFile Original CL: https://codereview.chromium.org/336923002/ BUG=384650 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282536

Patch Set 1 : Original CL #

Patch Set 2 : Fixes memory leak. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+397 lines, -147 lines)			Patch
M	chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc	View		2 chunks	+8 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/image_writer_private_apitest.cc	View		3 chunks	+83 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/operation.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/operation.cc	View		4 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/operation_unittest.cc	View		9 chunks	+25 lines, -31 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/test_utils.h	View		4 chunks	+54 lines, -26 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/test_utils.cc	View	1	6 chunks	+102 lines, -27 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc	View		3 chunks	+13 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc	View		6 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/image_writer_private/list_devices/test.js	View		2 chunks	+5 lines, -5 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/image_writer_private/write_from_file/background.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	chrome/test/data/extensions/api_test/image_writer_private/write_from_file/manifest.json	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/image_writer_private/write_from_file/test.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/image_writer_private/write_from_file/test.js	View		1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Drew Haven

David, Mind taking a quick look at this CL for me? It fixes the memory ...

6 years, 5 months ago (2014-07-10 22:47:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haven@chromium.org/382053004/20001

6 years, 5 months ago (2014-07-10 23:40:40 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-11 02:24:03 UTC) #5

Message was sent while issue was closed.

Change committed as 282536

Expand Messages | Collapse Messages