chrome/browser/extensions/api/image_writer_private/operation.h - Issue 382053004: Adds API test for imageWriterPrivate.writeFromFile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation.h

Issue 382053004: Adds API test for imageWriterPrivate.writeFromFile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes memory leak. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/image_writer_private/operation.h

diff --git a/chrome/browser/extensions/api/image_writer_private/operation.h b/chrome/browser/extensions/api/image_writer_private/operation.h

index b7c467034a12b0292c7db7ebc032cf4380e5eb52..1111d9f45ba90a4e3697499a37f89cb6a164404f 100644

--- a/chrome/browser/extensions/api/image_writer_private/operation.h

+++ b/chrome/browser/extensions/api/image_writer_private/operation.h

@@ -73,8 +73,10 @@ class Operation : public base::RefCountedThreadSafe<Operation> {

image_writer_api::Stage GetStage();

#if !defined(OS_CHROMEOS)

- // Set an ImageWriterClient to use. Should be called only when testing.

- void SetUtilityClientForTesting(

+ // Set an ImageWriterClient to use. Should be called only when testing. This

+ // does not set up automatic shutdown of the client and it must be shutdown

+ // manually.

+ static void SetUtilityClientForTesting(

scoped_refptr<ImageWriterUtilityClient> client);

#endif