Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc

Issue 382053004: Adds API test for imageWriterPrivate.writeFromFile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes memory leak. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
diff --git a/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc b/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
index 67844e25361eb8c2c8d7fd6f6205995d95e3a890..dbda8b0468b7927ff3f65b15c670b8a88c7862d3 100644
--- a/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
+++ b/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
@@ -58,8 +58,7 @@ KeyedService* BuildFakeExtensionSystem(content::BrowserContext* profile) {
namespace {
-class ImageWriterOperationManagerTest
- : public ImageWriterUnitTestBase {
+class ImageWriterOperationManagerTest : public ImageWriterUnitTestBase {
public:
void StartCallback(bool success, const std::string& error) {
started_ = true;
@@ -111,11 +110,11 @@ TEST_F(ImageWriterOperationManagerTest, WriteFromFile) {
OperationManager manager(&test_profile_);
manager.StartWriteFromFile(
- kDummyExtensionId,
- test_image_path_,
- test_device_path_.AsUTF8Unsafe(),
- base::Bind(&ImageWriterOperationManagerTest::StartCallback,
- base::Unretained(this)));
+ kDummyExtensionId,
+ test_utils_.GetImagePath(),
+ test_utils_.GetDevicePath().AsUTF8Unsafe(),
+ base::Bind(&ImageWriterOperationManagerTest::StartCallback,
+ base::Unretained(this)));
EXPECT_TRUE(started_);
EXPECT_TRUE(start_success_);
@@ -138,7 +137,7 @@ TEST_F(ImageWriterOperationManagerTest, DestroyPartitions) {
manager.DestroyPartitions(
kDummyExtensionId,
- test_device_path_.AsUTF8Unsafe(),
+ test_utils_.GetDevicePath().AsUTF8Unsafe(),
base::Bind(&ImageWriterOperationManagerTest::StartCallback,
base::Unretained(this)));

Powered by Google App Engine
This is Rietveld 408576698