Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 381893002: Do not specify language for font fallback (Closed)

Created:
6 years, 5 months ago by Dominik Röttsches
Modified:
6 years, 5 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Do not specify language for font fallback Providing the default locale as language when searching for a fallback font does not improve results. BUG=392724 R=eae,eseidel,abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178350

Patch Set 1 #

Patch Set 2 : Empty string instead of null argument #

Patch Set 3 : Passing rebaseline job to bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M Source/platform/exported/linux/WebFontInfo.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Dominik Röttsches
Change required on the Chromium side that allows 0 values to go through IPC.
6 years, 5 months ago (2014-07-10 12:41:35 UTC) #1
Dominik Röttsches
Chromium side change in https://codereview.chromium.org/380243002/
6 years, 5 months ago (2014-07-10 12:47:29 UTC) #2
eae
LGTM
6 years, 5 months ago (2014-07-11 09:56:48 UTC) #3
Dominik Röttsches
The review in https://codereview.chromium.org/380243002/ didn't go as planned. IPC review folks prefer not to have ...
6 years, 5 months ago (2014-07-15 15:20:23 UTC) #4
Dominik Röttsches
Looks like I better let the bot do the rebaselines instead of uploading results - ...
6 years, 5 months ago (2014-07-15 23:02:06 UTC) #5
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 5 months ago (2014-07-16 10:28:10 UTC) #6
Dominik Röttsches
The CQ bit was unchecked by dominik.rottsches@intel.com
6 years, 5 months ago (2014-07-16 10:28:10 UTC) #7
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 5 months ago (2014-07-17 08:25:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/381893002/40001
6 years, 5 months ago (2014-07-17 08:26:38 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-17 09:13:49 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 09:45:27 UTC) #11
Message was sent while issue was closed.
Change committed as 178350

Powered by Google App Engine
This is Rietveld 408576698