Source/platform/fonts/skia/FontCacheSkia.cpp - Issue 381893002: Do not specify language for font fallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/skia/FontCacheSkia.cpp

Issue 381893002: Do not specify language for font fallback (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Passing rebaseline job to bots Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/skia/FontCacheSkia.cpp

diff --git a/Source/platform/fonts/skia/FontCacheSkia.cpp b/Source/platform/fonts/skia/FontCacheSkia.cpp

index a21fed4868ed198bd524c2879bc372cb115478d9..cb00aa3bb564a0bf68b45f293283f5efd8a5db84 100644

--- a/Source/platform/fonts/skia/FontCacheSkia.cpp

+++ b/Source/platform/fonts/skia/FontCacheSkia.cpp

@@ -96,9 +96,8 @@ PassRefPtr<SimpleFontData> FontCache::fallbackFontForCharacter(const FontDescrip

return fontData;

}

- icu::Locale locale = icu::Locale::getDefault();

FontCache::PlatformFallbackFont fallbackFont;

- FontCache::getFontForCharacter(c, locale.getLanguage(), &fallbackFont);

+ FontCache::getFontForCharacter(c, "", &fallbackFont);

if (fallbackFont.name.isEmpty())

return nullptr;

« no previous file with comments | « Source/platform/exported/linux/WebFontInfo.cpp ('k') | no next file » | no next file with comments »