Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: base/sys_info_android.cc

Issue 381813002: base: Default android version to 4.4.99 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info_android.cc
diff --git a/base/sys_info_android.cc b/base/sys_info_android.cc
index ab7c05d7c6f00686baac50e539256f95a728ff92..92eefef6527b0ad29a44be05663e1bf7a9b02442 100644
--- a/base/sys_info_android.cc
+++ b/base/sys_info_android.cc
@@ -17,11 +17,12 @@
namespace {
// Default version of Android to fall back to when actual version numbers
-// cannot be acquired. This is an obviously invalid version number. Code
-// doing version comparison should treat it as so and fail all comparisons.
-const int kDefaultAndroidMajorVersion = 0;
-const int kDefaultAndroidMinorVersion = 0;
-const int kDefaultAndroidBugfixVersion = 0;
+// cannot be acquired. Use the latest Android release with a higher bug fix
+// version to avoid unnecessarily comparison errors with the latest release.
+// This should be manually kept up-to-date on each Android release.
+const int kDefaultAndroidMajorVersion = 4;
+const int kDefaultAndroidMinorVersion = 4;
+const int kDefaultAndroidBugfixVersion = 99;
// Parse out the OS version numbers from the system properties.
void ParseOSVersionNumbers(const char* os_version_str,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698