Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 381813002: base: Default android version to 4.4.99 (Closed)

Created:
6 years, 5 months ago by boliu
Modified:
6 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, joth
Project:
chromium
Visibility:
Public.

Description

base: Default android version to 4.4.99 Under-development Android versions do not have a numeric version, so falls back to a "default version". Using a real released Android version like 4.3.0 will incorrectly trigger code paths, such has version-specific gpu blacklists. First attempt at fixing this was using 0.0.0, which caused websites parsing Android version in the user agent to break. So this is the second attempt, use the latest public major version and minor version, and use a higher bug release version to avoid conflicts with the gpu blacklist. BUG=387179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M base/sys_info_android.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
boliu
PTAL. Gonna wait for approval this time :)
6 years, 5 months ago (2014-07-09 22:56:31 UTC) #1
boliu
For reference, there's an internal chrome-team thread discussion about this.
6 years, 5 months ago (2014-07-10 00:01:23 UTC) #2
willchan no longer on Chromium
+joth Please update the changelist description with the motivation for doing this.
6 years, 5 months ago (2014-07-10 00:09:10 UTC) #3
boliu
Updated description.
6 years, 5 months ago (2014-07-10 00:16:40 UTC) #4
no sievers
lgtm
6 years, 5 months ago (2014-07-10 00:18:17 UTC) #5
willchan no longer on Chromium
lgtm
6 years, 5 months ago (2014-07-10 00:18:59 UTC) #6
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 5 months ago (2014-07-10 00:20:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/381813002/1
6 years, 5 months ago (2014-07-10 00:20:59 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 08:05:25 UTC) #9
Message was sent while issue was closed.
Change committed as 282281

Powered by Google App Engine
This is Rietveld 408576698