base: Default android version to 4.4.99

base/sys_info_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_info.h"
 
 #include <sys/system_properties.h>
 
 #include "base/android/sys_utils.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"
 #include "base/sys_info_internal.h"
 
 namespace {
 
 // Default version of Android to fall back to when actual version numbers
-// cannot be acquired. This is an obviously invalid version number. Code
-// doing version comparison should treat it as so and fail all comparisons.
-const int kDefaultAndroidMajorVersion = 0;
-const int kDefaultAndroidMinorVersion = 0;
-const int kDefaultAndroidBugfixVersion = 0;
+// cannot be acquired. Use the latest Android release with a higher bug fix
+// version to avoid unnecessarily comparison errors with the latest release.
+// This should be manually kept up-to-date on each Android release.
+const int kDefaultAndroidMajorVersion = 4;
+const int kDefaultAndroidMinorVersion = 4;
+const int kDefaultAndroidBugfixVersion = 99;
 
 // Parse out the OS version numbers from the system properties.
 void ParseOSVersionNumbers(const char* os_version_str,
                            int32 *major_version,
                            int32 *minor_version,
                            int32 *bugfix_version) {
   if (os_version_str[0]) {
     // Try to parse out the version numbers from the string.
     int num_read = sscanf(os_version_str, "%d.%d.%d", major_version,
                           minor_version, bugfix_version);
@@ skipping 134 matching lines @@
     base::internal::LazySysInfoValue<bool,
         android::SysUtils::IsLowEndDeviceFromJni> >::Leaky
     g_lazy_low_end_device = LAZY_INSTANCE_INITIALIZER;
 
 bool SysInfo::IsLowEndDevice() {
   return g_lazy_low_end_device.Get().value();
 }
 
 
 }  // namespace base