[Autofill] Autofill fails to fill credit card number when split across fields.

components/autofill/core/browser/field_types.h

Index: components/autofill/core/browser/field_types.h
diff --git a/components/autofill/core/browser/field_types.h b/components/autofill/core/browser/field_types.h
index 75a5b92922ce2ab863283580fa92af5ef504d3b4..a0496fb2e4629cd6876e8a6d047974da8ddd1175 100644
--- a/components/autofill/core/browser/field_types.h
+++ b/components/autofill/core/browser/field_types.h
@@ -54,7 +54,6 @@ enum ServerFieldType {
   PHONE_FAX_WHOLE_NUMBER = 24,
 
   // Cell phone numbers (values [25, 29]) are deprecated.
-

[kbalazs, 2014/07/25 00:30:08]

These changes are unrelevant and useless, please remove (i.e. add back the empty
lines).

[Pritam Nikam, 2014/07/26 11:29:51]

These are aftereffects of CL format.

   ADDRESS_HOME_LINE1 = 30,
   ADDRESS_HOME_LINE2 = 31,
   ADDRESS_HOME_APT_NUM = 32,
@@ -71,7 +70,6 @@ enum ServerFieldType {
   ADDRESS_BILLING_COUNTRY = 43,
 
   // ADDRESS_SHIPPING values [44,50] are deprecated.
-
   CREDIT_CARD_NAME = 51,
   CREDIT_CARD_NUMBER = 52,
   CREDIT_CARD_EXP_MONTH = 53,
@@ -81,18 +79,15 @@ enum ServerFieldType {
   CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR = 57,
   CREDIT_CARD_TYPE = 58,
   CREDIT_CARD_VERIFICATION_CODE = 59,
-
   COMPANY_NAME = 60,
 
   // Generic type whose default value is known.
   FIELD_WITH_DEFAULT_VALUE = 61,
-
   PHONE_BILLING_NUMBER = 62,
   PHONE_BILLING_CITY_CODE = 63,
   PHONE_BILLING_COUNTRY_CODE = 64,
   PHONE_BILLING_CITY_AND_NUMBER = 65,
   PHONE_BILLING_WHOLE_NUMBER = 66,
-
   NAME_BILLING_FIRST = 67,
   NAME_BILLING_MIDDLE = 68,
   NAME_BILLING_LAST = 69,
@@ -135,11 +130,14 @@ enum ServerFieldType {
   // The third line of the street address.
   ADDRESS_HOME_LINE3 = 83,
   ADDRESS_BILLING_LINE3 = 84,
+  CREDIT_CARD_NUMBER_PART1 = 85,
+  CREDIT_CARD_NUMBER_PART2 = 86,
+  CREDIT_CARD_NUMBER_PART3 = 87,
+  CREDIT_CARD_NUMBER_PART4 = 88,
 
   // No new types can be added without a corresponding change to the Autofill
   // server.

[Ilya Sherman, 2014/07/25 03:37:49]

As indicated by this comment, it's not appropriate to make changes to this file
without server-side changes.  Are you sure that new types are needed?  If so, we
can potentially add corresponding server types ... though that would require a
fairly strong case to be made for these new field types.

[Pritam Nikam, 2014/07/26 11:29:50]

In my opinion this is required. I didn't find any easy alternative to identify a
split in credit card number field and communicate it back till the end.

-
-  MAX_VALID_FIELD_TYPE = 85,
+  MAX_VALID_FIELD_TYPE = 89,
 };
 
 // The list of all HTML autocomplete field type hints supported by Chrome.
@@ -168,7 +166,7 @@ enum HtmlFieldType {
   HTML_TYPE_COUNTRY_CODE,    // The ISO 3166-1-alpha-2 country code.
   HTML_TYPE_COUNTRY_NAME,    // The localized country name.
   HTML_TYPE_POSTAL_CODE,
-  HTML_TYPE_FULL_ADDRESS,    // The complete address, formatted for display.
+  HTML_TYPE_FULL_ADDRESS,  // The complete address, formatted for display.
 
   // Credit card types.
   HTML_TYPE_CREDIT_CARD_NAME,
@@ -204,6 +202,10 @@ enum HtmlFieldType {
   HTML_TYPE_CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR,
   HTML_TYPE_CREDIT_CARD_EXP_2_DIGIT_YEAR,
   HTML_TYPE_CREDIT_CARD_EXP_4_DIGIT_YEAR,
+  HTML_TYPE_CREDIT_CARD_NUMBER_PART1,
+  HTML_TYPE_CREDIT_CARD_NUMBER_PART2,
+  HTML_TYPE_CREDIT_CARD_NUMBER_PART3,
+  HTML_TYPE_CREDIT_CARD_NUMBER_PART4

[Ilya Sherman, 2014/07/25 03:37:49]

It's not appropriate to add new HTML field types without changes to the HTML
specification.  In this case, I don't think the HTML specification will be
changing to support these field types, as they do not follow best practices.

[Pritam Nikam, 2014/07/26 11:29:50]

Done.

 };
 
 // The list of all HTML autocomplete field mode hints supported by Chrome.