components/autofill/core/browser/personal_data_manager.cc - Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/field_types.h ('K') | « components/autofill/core/browser/field_types.h ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.cc

diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc

index d5645559cc3f6cd51d6e9dc338042914599e35ba..f0a2185dffec5269c5ce5630c9e18a14cc351ca0 100644

--- a/components/autofill/core/browser/personal_data_manager.cc

+++ b/components/autofill/core/browser/personal_data_manager.cc

@@ -672,7 +672,7 @@ void PersonalDataManager::GetCreditCardSuggestions(

creditcard_field_value = credit_card->ObfuscatedNumber();

base::string16 label;

- if (credit_card->number().empty()) {

+ if (credit_card->GetNumber().empty()) {

// If there is no CC number, return name to show something.

label =

credit_card->GetInfo(AutofillType(CREDIT_CARD_NAME), app_locale_);

@@ -1013,7 +1013,7 @@ void PersonalDataManager::NotifyPersonalDataChanged() {

std::string PersonalDataManager::SaveImportedCreditCard(

const CreditCard& imported_card) {

- DCHECK(!imported_card.number().empty());

+ DCHECK(!imported_card.GetNumber().empty());

if (is_off_the_record_)

return std::string();