components/autofill/core/browser/credit_card_unittest.cc - Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/credit_card_unittest.cc

Issue 381613005: [Autofill] Autofill fails to fill credit card number when split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/credit_card.h ('K') | « components/autofill/core/browser/credit_card_field.cc ('k') | components/autofill/core/browser/field_types.h » ('j') | components/autofill/core/browser/field_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/credit_card_unittest.cc

diff --git a/components/autofill/core/browser/credit_card_unittest.cc b/components/autofill/core/browser/credit_card_unittest.cc

index 28823fb1e313326a5130aca5a23fcbbe1e33c2ef..e5db9f486c6d844bdfe5a9074ab18909f03c2056 100644

--- a/components/autofill/core/browser/credit_card_unittest.cc

+++ b/components/autofill/core/browser/credit_card_unittest.cc

@@ -309,7 +309,7 @@ TEST(CreditCardTest, SetRawInfoCreditCardNumber) {

test::SetCreditCardInfo(&card, "Bob Dylan",

"4321-5432-6543-xxxx", "07", "2013");

- EXPECT_EQ(ASCIIToUTF16("4321-5432-6543-xxxx"),

+ EXPECT_EQ(ASCIIToUTF16("432154326543xxxx"),

kbalazs 2014/07/25 00:30:08 Shouldn't we add a new test case instead of changi

Ilya Sherman 2014/07/25 03:37:49 +1. Your changes should not regress this test.

Pritam Nikam 2014/07/26 11:29:50 Done.

card.GetRawInfo(CREDIT_CARD_NUMBER));

}