[Autofill] Autofill fails to fill credit card number when split across fields.

components/autofill/core/browser/credit_card_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/guid.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/credit_card.h"
@@ skipping 291 matching lines @@
   EXPECT_EQ(kMasterCard, card.type());
   EXPECT_FALSE(card.IsComplete());
 }
 
 // Verify that we preserve exactly what the user typed for credit card numbers.
 TEST(CreditCardTest, SetRawInfoCreditCardNumber) {
   CreditCard card(base::GenerateGUID(), "https://www.example.com/");
 
   test::SetCreditCardInfo(&card, "Bob Dylan",
                           "4321-5432-6543-xxxx", "07", "2013");
-  EXPECT_EQ(ASCIIToUTF16("4321-5432-6543-xxxx"),
+  EXPECT_EQ(ASCIIToUTF16("432154326543xxxx"),

[kbalazs, 2014/07/25 00:30:08]

Shouldn't we add a new test case instead of changing an existing one?

[Ilya Sherman, 2014/07/25 03:37:49]

+1.  Your changes should not regress this test.

[Pritam Nikam, 2014/07/26 11:29:50]

Done.

[Pritam Nikam, 2014/07/26 11:29:50]

Done.

             card.GetRawInfo(CREDIT_CARD_NUMBER));
 }
 
 // Verify that we can handle both numeric and named months.
 TEST(CreditCardTest, SetExpirationMonth) {
   CreditCard card(base::GenerateGUID(), "https://www.example.com/");
 
   card.SetRawInfo(CREDIT_CARD_EXP_MONTH, ASCIIToUTF16("05"));
   EXPECT_EQ(ASCIIToUTF16("05"), card.GetRawInfo(CREDIT_CARD_EXP_MONTH));
   EXPECT_EQ(5, card.expiration_month());
@@ skipping 197 matching lines @@
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
     base::string16 card_number = ASCIIToUTF16(test_cases[i].card_number);
     SCOPED_TRACE(card_number);
     EXPECT_EQ(test_cases[i].type, CreditCard::GetCreditCardType(card_number));
     EXPECT_EQ(test_cases[i].is_valid, IsValidCreditCardNumber(card_number));
   }
 }
 
 }  // namespace autofill