Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 381583007: Ephemeral apps should not appear in ChromeOS file manager menus (Closed)

Created:
6 years, 5 months ago by tmdiep
Modified:
6 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ephemeral apps should not appear in ChromeOS file manager menus Ephemeral apps should not be used to open files via the ChromeOS file manager as they are not permanently installed. BUG=391145 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks_unittest.cc View 5 chunks +64 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tmdiep
Some background for this patch: Ephemeral apps should not be listed in the context menus ...
6 years, 5 months ago (2014-07-10 05:50:07 UTC) #1
satorux1
defer to kinaba@
6 years, 5 months ago (2014-07-10 05:51:19 UTC) #2
kinaba
lgtm. The change should cover all the cases.
6 years, 5 months ago (2014-07-10 07:00:46 UTC) #3
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 5 months ago (2014-07-10 08:00:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/381583007/1
6 years, 5 months ago (2014-07-10 08:01:44 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 11:23:55 UTC) #6
Message was sent while issue was closed.
Change committed as 282312

Powered by Google App Engine
This is Rietveld 408576698