chrome/browser/chromeos/file_manager/file_tasks.cc - Issue 381583007: Ephemeral apps should not appear in ChromeOS file manager menus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/file_tasks.cc

Issue 381583007: Ephemeral apps should not appear in ChromeOS file manager menus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/file_browser_handlers.cc ('k') | chrome/browser/chromeos/file_manager/file_tasks_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_manager/file_tasks.cc

diff --git a/chrome/browser/chromeos/file_manager/file_tasks.cc b/chrome/browser/chromeos/file_manager/file_tasks.cc

index ae49d19b723b7f8e5e818ca19ac600a3de10dbc0..3fc7ec0e8b738e510798fdb1268889601057b281 100644

--- a/chrome/browser/chromeos/file_manager/file_tasks.cc

+++ b/chrome/browser/chromeos/file_manager/file_tasks.cc

@@ -29,6 +29,7 @@

#include "extensions/browser/extension_host.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/browser/extension_util.h"

#include "extensions/common/constants.h"

#include "extensions/common/extension_set.h"

#include "google_apis/drive/gdata_wapi_parser.h"

@@ -384,6 +385,10 @@ void FindFileHandlerTasks(

if (!extension->is_platform_app())

continue;

+ // Ephemeral apps cannot be file handlers.

+ if (extensions::util::IsEphemeralApp(extension->id(), profile))

+ continue;

if (profile->IsOffTheRecord() &&

!extensions::util::IsIncognitoEnabled(extension->id(), profile))

continue;