Ephemeral apps should not appear in ChromeOS file manager menus

chrome/browser/chromeos/file_manager/file_tasks_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_manager/file_tasks.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/app_id.h"
 #include "chrome/browser/chromeos/login/users/user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #include "chrome/browser/drive/drive_app_registry.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
+#include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/extension_builder.h"
 #include "google_apis/drive/drive_api_parser.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace file_manager {
 namespace file_tasks {
 namespace {
 
@@ skipping 337 matching lines @@
   CommandLine command_line_;
   ExtensionService* extension_service_;  // Owned by test_profile_;
 };
 
 // The basic logic is similar to a test case for FindDriveAppTasks above.
 TEST_F(FileManagerFileTasksComplexTest, FindFileHandlerTasks) {
   // Random IDs generated by
   // % ruby -le 'print (0...32).to_a.map{(?a + rand(16)).chr}.join'
   const char kFooId[] = "hhgbjpmdppecanaaogonaigmmifgpaph";
   const char kBarId[] = "odlhccgofgkadkkhcmhgnhgahonahoca";
+  const char kEphemeralId[] = "opoomfdlbjcbjinalcjdjfoiikdeaoel";
 
   // Foo.app can handle "text/plain" and "text/html".
   extensions::ExtensionBuilder foo_app;
   foo_app.SetManifest(extensions::DictionaryBuilder()
                       .Set("name", "Foo")
                       .Set("version", "1.0.0")
                       .Set("manifest_version", 2)
                       .Set("app",
                            extensions::DictionaryBuilder()
                            .Set("background",
@@ skipping 30 matching lines @@
                            extensions::DictionaryBuilder()
                            .Set("text",
                                 extensions::DictionaryBuilder()
                                 .Set("title", "Text")
                                 .Set("types",
                                      extensions::ListBuilder()
                                      .Append("text/plain")))));
   bar_app.SetID(kBarId);
   extension_service_->AddExtension(bar_app.Build().get());
 
+  // Ephemeral.app is an ephemeral app that can handle "text/plain".
+  // It should not ever be found as ephemeral apps cannot be file handlers.
+  extensions::ExtensionBuilder ephemeral_app;
+  ephemeral_app.SetManifest(
+      extensions::DictionaryBuilder()
+          .Set("name", "Ephemeral")
+          .Set("version", "1.0.0")
+          .Set("manifest_version", 2)
+          .Set("app",
+               extensions::DictionaryBuilder().Set(
+                   "background",
+                   extensions::DictionaryBuilder().Set(
+                       "scripts",
+                       extensions::ListBuilder().Append("background.js"))))
+          .Set("file_handlers",
+               extensions::DictionaryBuilder().Set(
+                   "text",
+                   extensions::DictionaryBuilder().Set("title", "Text").Set(
+                       "types",
+                       extensions::ListBuilder().Append("text/plain")))));
+  ephemeral_app.SetID(kEphemeralId);
+  scoped_refptr<extensions::Extension> built_ephemeral_app(
+      ephemeral_app.Build());
+  extension_service_->AddExtension(built_ephemeral_app.get());
+  extensions::ExtensionPrefs* extension_prefs =
+      extensions::ExtensionPrefs::Get(&test_profile_);
+  extension_prefs->OnExtensionInstalled(built_ephemeral_app.get(),
+                                        extensions::Extension::ENABLED,
+                                        syncer::StringOrdinal(),
+                                        extensions::kInstallFlagIsEphemeral,
+                                        std::string());
+
   // Find apps for a "text/plain" file. Foo.app and Bar.app should be found.
   PathAndMimeTypeSet path_mime_set;
   path_mime_set.insert(
       std::make_pair(
           drive::util::GetDriveMountPointPath(&test_profile_).AppendASCII(
               "foo.txt"),
           "text/plain"));
 
   std::vector<FullTaskDescriptor> tasks;
   FindFileHandlerTasks(&test_profile_, path_mime_set, &tasks);
@@ skipping 34 matching lines @@
   FindFileHandlerTasks(&test_profile_, path_mime_set, &tasks);
   // Confirm no tasks are found.
   ASSERT_TRUE(tasks.empty());
 }
 
 // The basic logic is similar to a test case for FindDriveAppTasks above.
 TEST_F(FileManagerFileTasksComplexTest, FindFileBrowserHandlerTasks) {
   // Copied from FindFileHandlerTasks test above.
   const char kFooId[] = "hhgbjpmdppecanaaogonaigmmifgpaph";
   const char kBarId[] = "odlhccgofgkadkkhcmhgnhgahonahoca";
+  const char kEphemeralId[] = "opoomfdlbjcbjinalcjdjfoiikdeaoel";
 
   // Foo.app can handle ".txt" and ".html".
   // This one is an extension, and has "file_browser_handlers"
   extensions::ExtensionBuilder foo_app;
   foo_app.SetManifest(extensions::DictionaryBuilder()
                       .Set("name", "Foo")
                       .Set("version", "1.0.0")
                       .Set("manifest_version", 2)
                       .Set("file_browser_handlers",
                            extensions::ListBuilder()
@@ skipping 17 matching lines @@
                            extensions::ListBuilder()
                            .Append(extensions::DictionaryBuilder()
                                    .Set("id", "open")
                                    .Set("default_title", "open")
                                    .Set("file_filters",
                                         extensions::ListBuilder()
                                         .Append("filesystem:*.txt")))));
   bar_app.SetID(kBarId);
   extension_service_->AddExtension(bar_app.Build().get());
 
+  // Ephemeral.app is an ephemeral app that can handle ".txt".
+  // It should not ever be found as ephemeral apps cannot be file browser
+  // handlers.
+  extensions::ExtensionBuilder ephemeral_app;
+  ephemeral_app.SetManifest(
+      extensions::DictionaryBuilder()
+          .Set("name", "Ephemeral")
+          .Set("version", "1.0.0")
+          .Set("manifest_version", 2)
+          .Set("file_browser_handlers",
+               extensions::ListBuilder().Append(
+                   extensions::DictionaryBuilder()
+                       .Set("id", "open")
+                       .Set("default_title", "open")
+                       .Set("file_filters",
+                            extensions::ListBuilder().Append(
+                                "filesystem:*.txt")))));
+  ephemeral_app.SetID(kEphemeralId);
+  scoped_refptr<extensions::Extension> built_ephemeral_app(
+      ephemeral_app.Build());
+  extension_service_->AddExtension(built_ephemeral_app.get());
+  extensions::ExtensionPrefs* extension_prefs =
+      extensions::ExtensionPrefs::Get(&test_profile_);
+  extension_prefs->OnExtensionInstalled(built_ephemeral_app.get(),
+                                        extensions::Extension::ENABLED,
+                                        syncer::StringOrdinal(),
+                                        extensions::kInstallFlagIsEphemeral,
+                                        std::string());
+
   // Find apps for a ".txt" file. Foo.app and Bar.app should be found.
   std::vector<GURL> file_urls;
   file_urls.push_back(GURL("filesystem:chrome-extension://id/dir/foo.txt"));
 
   std::vector<FullTaskDescriptor> tasks;
   FindFileBrowserHandlerTasks(&test_profile_, file_urls, &tasks);
   ASSERT_EQ(2U, tasks.size());
   // Sort the app IDs, as the order is not guaranteed.
   std::vector<std::string> app_ids;
   app_ids.push_back(tasks[0].task_descriptor().app_id);
@@ skipping 196 matching lines @@
                       &drive_app_registry,
                       path_mime_set,
                       file_urls,
                       &tasks);
   ASSERT_EQ(1U, tasks.size());
   EXPECT_EQ(kFileManagerAppId, tasks[0].task_descriptor().app_id);
 }
 
 }  // namespace file_tasks
 }  // namespace file_manager.