Update the CrxInstaller and UnpackedInstaller to use the ExtensionInstallChecker

Update the CrxInstaller and UnpackedInstaller to use the ExtensionInstallChecker

This patch removes the deprecated ExtensionInstaller and uses
ExtensionInstallChecker in CrxInstaller and UnpackedInstaller.

BUG=386404
TEST=browser_tests
TBR=pam@chromium.org (for include in supervised_user_service_unittest.cc)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282250

[tmdiep, 2014-07-09 05:09:29]

I refactored ExtensionInstaller a few weeks back in this CL:
https://codereview.chromium.org/339103002. Just revisiting this and updating
CrxInstaller and UnpackedInstaller to use the new ExtensionInstallChecker.

Thanks in advance.

[asargent_no_longer_on_chrome, 2014-07-09 23:54:16]

lgtm, thanks for coming back around to do this!

https://codereview.chromium.org/381553002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/crx_installer.cc (right):

https://codereview.chromium.org/381553002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/crx_installer.cc:48: #include
"extensions/browser/management_policy.h"
Do you actually use anything from this header file in this file? At a quick
glance, I didn't see anything, but maybe I missed it.

[tmdiep, 2014-07-10 00:26:24]

Thanks for the review!

https://codereview.chromium.org/381553002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/crx_installer.cc (right):

https://codereview.chromium.org/381553002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/crx_installer.cc:48: #include
"extensions/browser/management_policy.h"
On 2014/07/09 23:54:16, Antony Sargent wrote:
> Do you actually use anything from this header file in this file? At a quick
> glance, I didn't see anything, but maybe I missed it. 

You're right, it's not used in this file. I intended to add it to the browser
test.

[tmdiep, 2014-07-10 01:12:44]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-07-10 01:13:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tmdiep@chromium.org/381553002/40001

[commit-bot: I haz the power, 2014-07-10 03:41:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[tmdiep, 2014-07-10 03:43:21]

The CQ bit was unchecked by tmdiep@chromium.org

[tmdiep, 2014-07-10 03:47:00]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-07-10 03:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 03:47:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[tmdiep, 2014-07-10 04:18:45]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-07-10 04:19:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tmdiep@chromium.org/381553002/40001

[commit-bot: I haz the power, 2014-07-10 04:21:28]

Change committed as 282250