Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 381553002: Update the CrxInstaller and UnpackedInstaller to use the ExtensionInstallChecker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved include to correct file Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.h
diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h
index 024931d02eb83313a646c7b96ae86199a37b94e7..81a3b680a72f7b3849cdd1c8ecfabfa6d18c8e21 100644
--- a/chrome/browser/extensions/crx_installer.h
+++ b/chrome/browser/extensions/crx_installer.h
@@ -14,8 +14,8 @@
#include "base/memory/weak_ptr.h"
#include "base/version.h"
#include "chrome/browser/extensions/blacklist.h"
+#include "chrome/browser/extensions/extension_install_checker.h"
#include "chrome/browser/extensions/extension_install_prompt.h"
-#include "chrome/browser/extensions/extension_installer.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/sandboxed_unpacker.h"
#include "chrome/browser/extensions/webstore_installer.h"
@@ -195,9 +195,9 @@ class CrxInstaller
bool did_handle_successfully() const { return did_handle_successfully_; }
- Profile* profile() { return installer_.profile(); }
+ Profile* profile() { return install_checker_.profile(); }
- const Extension* extension() { return installer_.extension().get(); }
+ const Extension* extension() { return install_checker_.extension().get(); }
const std::string& current_version() const { return current_version_; }
@@ -229,11 +229,12 @@ class CrxInstaller
const Extension* extension,
const SkBitmap& install_icon) OVERRIDE;
- // Called on the UI thread to start the requirements check on the extension.
- void CheckImportsAndRequirements();
+ // Called on the UI thread to start the requirements, policy and blacklist
+ // checks on the extension.
+ void CheckInstall();
- // Runs on the UI thread. Callback from RequirementsChecker.
- void OnRequirementsChecked(std::vector<std::string> requirement_errors);
+ // Runs on the UI thread. Callback from ExtensionInstallChecker.
+ void OnInstallChecksComplete(int failed_checks);
// Runs on the UI thread. Callback from Blacklist.
void OnBlacklistChecked(
@@ -417,8 +418,8 @@ class CrxInstaller
// The flags for ExtensionService::OnExtensionInstalled.
int install_flags_;
- // Gives access to common methods and data of an extension installer.
- ExtensionInstaller installer_;
+ // Performs requirements, policy and blacklist checks on the extension.
+ ExtensionInstallChecker install_checker_;
DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
};
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698