Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Side by Side Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 381553002: Update the CrxInstaller and UnpackedInstaller to use the ExtensionInstallChecker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved include to correct file Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/at_exit.h" 5 #include "base/at_exit.h"
6 #include "base/memory/ref_counted.h" 6 #include "base/memory/ref_counted.h"
7 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/browser/download/download_crx_util.h" 8 #include "chrome/browser/download/download_crx_util.h"
8 #include "chrome/browser/extensions/browser_action_test_util.h" 9 #include "chrome/browser/extensions/browser_action_test_util.h"
9 #include "chrome/browser/extensions/crx_installer.h" 10 #include "chrome/browser/extensions/crx_installer.h"
10 #include "chrome/browser/extensions/extension_browsertest.h" 11 #include "chrome/browser/extensions/extension_browsertest.h"
11 #include "chrome/browser/extensions/extension_install_prompt.h" 12 #include "chrome/browser/extensions/extension_install_prompt.h"
12 #include "chrome/browser/extensions/extension_service.h" 13 #include "chrome/browser/extensions/extension_service.h"
13 #include "chrome/browser/extensions/extension_util.h" 14 #include "chrome/browser/extensions/extension_util.h"
14 #include "chrome/browser/extensions/fake_safe_browsing_database_manager.h" 15 #include "chrome/browser/extensions/fake_safe_browsing_database_manager.h"
15 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
17 #include "chrome/browser/ui/browser_window.h" 18 #include "chrome/browser/ui/browser_window.h"
18 #include "chrome/browser/ui/tabs/tab_strip_model.h" 19 #include "chrome/browser/ui/tabs/tab_strip_model.h"
19 #include "chrome/test/base/ui_test_utils.h" 20 #include "chrome/test/base/ui_test_utils.h"
20 #include "content/public/browser/browser_thread.h" 21 #include "content/public/browser/browser_thread.h"
21 #include "content/public/browser/download_manager.h" 22 #include "content/public/browser/download_manager.h"
22 #include "content/public/browser/render_view_host.h" 23 #include "content/public/browser/render_view_host.h"
23 #include "content/public/test/browser_test_utils.h" 24 #include "content/public/test/browser_test_utils.h"
24 #include "content/public/test/download_test_observer.h" 25 #include "content/public/test/download_test_observer.h"
25 #include "extensions/browser/extension_prefs.h" 26 #include "extensions/browser/extension_prefs.h"
26 #include "extensions/browser/extension_system.h" 27 #include "extensions/browser/extension_system.h"
28 #include "extensions/browser/management_policy.h"
27 #include "extensions/common/extension.h" 29 #include "extensions/common/extension.h"
28 #include "extensions/common/feature_switch.h" 30 #include "extensions/common/feature_switch.h"
29 #include "extensions/common/file_util.h" 31 #include "extensions/common/file_util.h"
30 #include "extensions/common/permissions/permission_set.h" 32 #include "extensions/common/permissions/permission_set.h"
31 #include "extensions/common/switches.h" 33 #include "extensions/common/switches.h"
32 #include "grit/generated_resources.h" 34 #include "grit/generated_resources.h"
33 #include "ui/base/l10n/l10n_util.h" 35 #include "ui/base/l10n/l10n_util.h"
34 36
35 #if defined(OS_CHROMEOS) 37 #if defined(OS_CHROMEOS)
36 #include "chrome/browser/chromeos/login/users/fake_user_manager.h" 38 #include "chrome/browser/chromeos/login/users/fake_user_manager.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 return prompt.PassAs<ExtensionInstallPrompt>(); 132 return prompt.PassAs<ExtensionInstallPrompt>();
131 } 133 }
132 134
133 135
134 scoped_refptr<MockPromptProxy> CreateMockPromptProxyForBrowser( 136 scoped_refptr<MockPromptProxy> CreateMockPromptProxyForBrowser(
135 Browser* browser) { 137 Browser* browser) {
136 return new MockPromptProxy( 138 return new MockPromptProxy(
137 browser->tab_strip_model()->GetActiveWebContents()); 139 browser->tab_strip_model()->GetActiveWebContents());
138 } 140 }
139 141
142 class ManagementPolicyMock : public extensions::ManagementPolicy::Provider {
143 public:
144 ManagementPolicyMock() {}
145
146 virtual std::string GetDebugPolicyProviderName() const OVERRIDE {
147 return "ManagementPolicyMock";
148 }
149
150 virtual bool UserMayLoad(const Extension* extension,
151 base::string16* error) const OVERRIDE {
152 *error = base::UTF8ToUTF16("Dummy error message");
153 return false;
154 }
155 };
156
140 } // namespace 157 } // namespace
141 158
142 class ExtensionCrxInstallerTest : public ExtensionBrowserTest { 159 class ExtensionCrxInstallerTest : public ExtensionBrowserTest {
143 public: 160 public:
144 scoped_ptr<WebstoreInstaller::Approval> GetApproval( 161 scoped_ptr<WebstoreInstaller::Approval> GetApproval(
145 const char* manifest_dir, 162 const char* manifest_dir,
146 const std::string& id, 163 const std::string& id,
147 bool strict_manifest_checks) { 164 bool strict_manifest_checks) {
148 scoped_ptr<WebstoreInstaller::Approval> result; 165 scoped_ptr<WebstoreInstaller::Approval> result;
149 166
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
543 EXPECT_TRUE(WaitForCrxInstallerDone()); 560 EXPECT_TRUE(WaitForCrxInstallerDone());
544 ASSERT_TRUE(crx_installer->extension()); 561 ASSERT_TRUE(crx_installer->extension());
545 562
546 const ExtensionPrefs* extension_prefs = 563 const ExtensionPrefs* extension_prefs =
547 ExtensionPrefs::Get(browser()->profile()); 564 ExtensionPrefs::Get(browser()->profile());
548 EXPECT_TRUE(extension_prefs->DoNotSync(crx_installer->extension()->id())); 565 EXPECT_TRUE(extension_prefs->DoNotSync(crx_installer->extension()->id()));
549 EXPECT_FALSE(extensions::util::ShouldSyncApp(crx_installer->extension(), 566 EXPECT_FALSE(extensions::util::ShouldSyncApp(crx_installer->extension(),
550 browser()->profile())); 567 browser()->profile()));
551 } 568 }
552 569
570 IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, ManagementPolicy) {
571 ManagementPolicyMock policy;
572 extensions::ExtensionSystem::Get(profile())
573 ->management_policy()
574 ->RegisterProvider(&policy);
575
576 base::FilePath crx_path = test_data_dir_.AppendASCII("crx_installer/v1.crx");
577 EXPECT_FALSE(InstallExtension(crx_path, 0));
578 }
579
553 } // namespace extensions 580 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_install_checker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698