Make CsvPageMeasurementResults not depend on

Make CsvPageMeasurementResults not depend on
all_value_names_that_have_been_seen.

This makes CsvPageMeasurementResults more self contained and allow
special casing of TraceValue (to be introduced) in
CsvPageMeasurementResults directly rather than in PageMeasurementResults.

This should be inline with the direction we are taking towards
OutputFormatter.

BUG=392901
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283435

[chrishenry, 2014-07-10 23:33:46]

What do you think of this?

[nednguyen, 2014-07-10 23:45:23]

lgtm

Please wait for Dave to LGTM this too.

https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/page_measurement_results.py (left):

https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/page_measurement_results.py:18:
self._representative_values_for_each_value_name = {}
Remove this dict?

[chrishenry, 2014-07-10 23:47:17]

https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/page_measurement_results.py (left):

https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/page_measurement_results.py:18:
self._representative_values_for_each_value_name = {}
On 2014/07/10 23:45:23, nednguyen wrote:
> Remove this dict?

This is being used to verify mergeability of values (line 80) so it can't be
removed.

[nednguyen, 2014-07-10 23:53:25]

On 2014/07/10 23:47:17, chrishenry wrote:
>
https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
> File tools/telemetry/telemetry/results/page_measurement_results.py (left):
> 
>
https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
> tools/telemetry/telemetry/results/page_measurement_results.py:18:
> self._representative_values_for_each_value_name = {}
> On 2014/07/10 23:45:23, nednguyen wrote:
> > Remove this dict?
> 
> This is being used to verify mergeability of values (line 80) so it can't be
> removed.
 I see.

[nednguyen, 2014-07-10 23:58:17]

https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/page_measurement_results.py (left):

https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/page_measurement_results.py:75:
self._representative_values_for_each_value_name[value.name] = value
The name _representative_values_for_each_value_name is deceiving. Let's change
it to _representative_value_for_each_value_name.

[chrishenry, 2014-07-14 17:41:00]

Dave, do you want to take a look at this? Thanks!

https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/page_measurement_results.py (left):

https://codereview.chromium.org/381303002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/page_measurement_results.py:75:
self._representative_values_for_each_value_name[value.name] = value
On 2014/07/10 23:58:17, nednguyen wrote:
> The name _representative_values_for_each_value_name is deceiving. Let's change
> it to _representative_value_for_each_value_name.

Done.

[nednguyen, 2014-07-15 16:43:24]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-07-15 16:44:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/381303002/40001

[commit-bot: I haz the power, 2014-07-16 00:52:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-16 01:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 01:23:40]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[chrishenry, 2014-07-16 02:15:55]

The CQ bit was checked by chrishenry@google.com

[commit-bot: I haz the power, 2014-07-16 02:17:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/381303002/40001

[commit-bot: I haz the power, 2014-07-16 03:37:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-16 04:08:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 04:08:47]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[chrishenry, 2014-07-16 14:28:24]

The CQ bit was checked by chrishenry@google.com

[commit-bot: I haz the power, 2014-07-16 14:30:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/381303002/40001

[commit-bot: I haz the power, 2014-07-16 18:20:04]

Change committed as 283435