Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: tools/telemetry/telemetry/results/page_measurement_results_unittest.py

Issue 381303002: Make CsvPageMeasurementResults not depend on (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comment + update doc. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/results/page_measurement_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/page_measurement_results_unittest.py
index 02fa5748ad6db6b0a5cd32db5556e2af04240bf7..12662a7a6492bf309863e11eb61cec4ecc64e99c 100644
--- a/tools/telemetry/telemetry/results/page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/results/page_measurement_results_unittest.py
@@ -73,19 +73,6 @@ class PageMeasurementResultsTest(unittest.TestCase):
lambda: results.AddValue(scalar.ScalarValue(
self.pages[0], 'url', 'string', 'foo')))
- def test_value_names_that_have_been_seen(self):
- results = NonPrintingPageMeasurementResults()
- results.WillMeasurePage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'a_units', 3))
- results.AddValue(scalar.ScalarValue(self.pages[0], 'b', 'b_units', 3))
- results.AddSummaryValue(scalar.ScalarValue(None, 'c', 'c_units', 3))
- results.DidMeasurePage()
- self.assertEquals(set(['a', 'b', 'c']),
- set(results.all_value_names_that_have_been_seen))
- self.assertEquals('a_units', results.GetUnitsForValueName('a'))
- self.assertEquals('b_units', results.GetUnitsForValueName('b'))
- self.assertEquals('c_units', results.GetUnitsForValueName('c'))
-
def test_add_summary_value_with_page_specified(self):
results = NonPrintingPageMeasurementResults()
results.WillMeasurePage(self.pages[0])
@@ -106,8 +93,6 @@ class PageMeasurementResultsTest(unittest.TestCase):
lambda: results.AddValue(scalar.ScalarValue(
self.pages[1], 'a', 'foobgrobbers', 3)))
- self.assertEquals(['a'], results.all_value_names_that_have_been_seen)
-
def test_type_change(self):
results = NonPrintingPageMeasurementResults()
results.WillMeasurePage(self.pages[0])
« no previous file with comments | « tools/telemetry/telemetry/results/page_measurement_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698