Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: tools/telemetry/telemetry/results/page_measurement_results.py

Issue 381303002: Make CsvPageMeasurementResults not depend on (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comment + update doc. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_measurement_results.py
diff --git a/tools/telemetry/telemetry/results/page_measurement_results.py b/tools/telemetry/telemetry/results/page_measurement_results.py
index 0949e1db721e94e227005ac2e4deec7a92c57ec0..45a57e57f4edd5d3af262b40a80436990151bce0 100644
--- a/tools/telemetry/telemetry/results/page_measurement_results.py
+++ b/tools/telemetry/telemetry/results/page_measurement_results.py
@@ -15,7 +15,7 @@ class PageMeasurementResults(page_test_results.PageTestResults):
self._current_page = None
self._page_specific_values_for_current_page = None
- self._representative_values_for_each_value_name = {}
+ self._representative_value_for_each_value_name = {}
self._all_summary_values = []
self._all_page_specific_values = []
@@ -31,13 +31,6 @@ class PageMeasurementResults(page_test_results.PageTestResults):
return self._current_page
@property
- def all_value_names_that_have_been_seen(self):
- return list(self._representative_values_for_each_value_name.keys())
-
- def GetUnitsForValueName(self, value_name):
- return self._representative_values_for_each_value_name[value_name].units
-
- @property
def all_page_specific_values(self):
return self._all_page_specific_values
@@ -70,13 +63,10 @@ class PageMeasurementResults(page_test_results.PageTestResults):
def _ValidateValue(self, value):
assert isinstance(value, value_module.Value)
-
- if value.name not in self._representative_values_for_each_value_name:
- self._representative_values_for_each_value_name[value.name] = value
-
- representative_value = self._representative_values_for_each_value_name[
+ if value.name not in self._representative_value_for_each_value_name:
+ self._representative_value_for_each_value_name[value.name] = value
+ representative_value = self._representative_value_for_each_value_name[
value.name]
-
assert value.IsMergableWith(representative_value)
def DidMeasurePage(self):

Powered by Google App Engine
This is Rietveld 408576698