Add alternate SkPicture::clone

Add alternate SkPicture::clone

This adds an alternate version of SkPicture::clone for two reasons:

1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor)

2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely.

Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/)

Committed: https://skia.googlesource.com/skia/+/e372e78223a8ce916d276d6e0420d552fb0267e9

[reed1, 2014-07-10 19:10:06]

lgtm

https://codereview.chromium.org/381193002/diff/1/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/381193002/diff/1/include/core/SkPicture.h#new...
include/core/SkPicture.h:125: void clone(SkPicture* pictures, int count) const;
What does the old version even mean? Can anyone (but the private impl) create an
array of Pictures themselves?

I guess as a convenience we could offer

clone(const SkPicture*)

which implicitly assumes a count of 1

[reed1, 2014-07-10 19:11:36]

On 2014/07/10 19:10:06, reed1 wrote:
> lgtm
> 
> https://codereview.chromium.org/381193002/diff/1/include/core/SkPicture.h
> File include/core/SkPicture.h (right):
> 
>
https://codereview.chromium.org/381193002/diff/1/include/core/SkPicture.h#new...
> include/core/SkPicture.h:125: void clone(SkPicture* pictures, int count)
const;
> What does the old version even mean? Can anyone (but the private impl) create
an
> array of Pictures themselves?
> 
> I guess as a convenience we could offer
> 
> clone(const SkPicture*)
> 
> which implicitly assumes a count of 1

OK, I forgot that picture has a public constructor, instead of a factory. But
still!

[mtklein, 2014-07-10 19:14:01]

https://codereview.chromium.org/381193002/diff/1/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/381193002/diff/1/src/core/SkPicture.cpp#newco...
src/core/SkPicture.cpp:205: 
Can we share somehow the code below here?  Looks identical?

https://codereview.chromium.org/381193002/diff/1/src/core/SkPicture.cpp#newco...
src/core/SkPicture.cpp:266: void SkPicture::clone(SkPicture* pictures[], int
count) const {
Can this be, for now,

void SkPicture::clone(SkPicture* pictures[], int count) const {
  for (int i = 0; i < count; i++) {
    pictures[i] = SkNEW(SkPicture);
  }
  clone(*pictures, count);
}

next to become

void SkPicture::clone(SkPicture* pictures[], int count) const {
  for (int i = 0; i < count; i++) {
    pictures[i] = this;
  }
}

?

[mtklein, 2014-07-10 19:22:27]

On 2014/07/10 19:14:01, mtklein wrote:
> https://codereview.chromium.org/381193002/diff/1/src/core/SkPicture.cpp
> File src/core/SkPicture.cpp (right):
> 
>
https://codereview.chromium.org/381193002/diff/1/src/core/SkPicture.cpp#newco...
> src/core/SkPicture.cpp:205: 
> Can we share somehow the code below here?  Looks identical?
> 
>
https://codereview.chromium.org/381193002/diff/1/src/core/SkPicture.cpp#newco...
> src/core/SkPicture.cpp:266: void SkPicture::clone(SkPicture* pictures[], int
> count) const {
> Can this be, for now,
> 
> void SkPicture::clone(SkPicture* pictures[], int count) const {
>   for (int i = 0; i < count; i++) {
>     pictures[i] = SkNEW(SkPicture);
>   }
>   clone(*pictures, count);
> }
> 
> next to become
> 
> void SkPicture::clone(SkPicture* pictures[], int count) const {
>   for (int i = 0; i < count; i++) {
>     pictures[i] = this;
>   }
> }
> 
> ?

lgtm

[robertphillips, 2014-07-10 19:24:08]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-07-10 19:24:56]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/robertphillips@google.com/381193002/1

[commit-bot: I haz the power, 2014-07-10 21:11:02]

Change committed as e372e78223a8ce916d276d6e0420d552fb0267e9

[robertphillips, 2014-07-11 13:45:15]

A revert of this CL has been created in
https://codereview.chromium.org/386933004/ by robertphillips@google.com.

The reason for reverting is: Going to try to just remove the many-at-once clone
interface.