Issue 381143002: Use a consume load in SkLazyPtr.

Issue 381143002: Use a consume load in SkLazyPtr. (Closed)

Created:
6 years, 5 months ago by mtklein_C

Modified:
6 years, 5 months ago

Reviewers:
bungeman-skia, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Use a consume load in SkLazyPtr. This only affects ARM, where an acquire needs a memory barrier but consume does not. I am interested to see if there's a noticeable effect on the Android bots. BUG=skia: NOTRY=true Committed: https://skia.googlesource.com/skia/+/654a9c20acb2e34b7836139615c29dc09fa0fb9c

Patch Set 1 #

Patch Set 2 : compiler barrier #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -4 lines)			Patch
M	src/core/SkLazyPtr.h	View		2 chunks	+16 lines, -4 lines	0 comments	Download
M	src/ports/SkBarriers_arm.h	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/ports/SkBarriers_tsan.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/ports/SkBarriers_x86.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

lgtm, let's see if anyone submits an Alpha version.

6 years, 5 months ago (2014-07-10 17:54:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/381143002/20001

6 years, 5 months ago (2014-07-10 17:55:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/381143002/20001

6 years, 5 months ago (2014-07-10 18:13:35 UTC) #7

commit-bot: I haz the power

6 years, 5 months ago (2014-07-10 18:24:21 UTC) #8

Message was sent while issue was closed.

Change committed as 654a9c20acb2e34b7836139615c29dc09fa0fb9c

Expand Messages | Collapse Messages