Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: src/ports/SkBarriers_tsan.h

Issue 381143002: Use a consume load in SkLazyPtr. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: compiler barrier Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ports/SkBarriers_arm.h ('k') | src/ports/SkBarriers_x86.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkBarriers_tsan_DEFINED 8 #ifndef SkBarriers_tsan_DEFINED
9 #define SkBarriers_tsan_DEFINED 9 #define SkBarriers_tsan_DEFINED
10 10
11 static inline void sk_compiler_barrier() { asm volatile("" : : : "memory"); } 11 static inline void sk_compiler_barrier() { asm volatile("" : : : "memory"); }
12 12
13 template <typename T> 13 template <typename T>
14 T sk_acquire_load(T* ptr) { 14 T sk_acquire_load(T* ptr) {
15 SkASSERT(__atomic_always_lock_free(sizeof(T), ptr)); 15 SkASSERT(__atomic_always_lock_free(sizeof(T), ptr));
16 return __atomic_load_n(ptr, __ATOMIC_ACQUIRE); 16 return __atomic_load_n(ptr, __ATOMIC_ACQUIRE);
17 } 17 }
18 18
19 template <typename T> 19 template <typename T>
20 T sk_consume_load(T* ptr) {
21 SkASSERT(__atomic_always_lock_free(sizeof(T), ptr));
22 return __atomic_load_n(ptr, __ATOMIC_CONSUME);
23 }
24
25 template <typename T>
20 void sk_release_store(T* ptr, T val) { 26 void sk_release_store(T* ptr, T val) {
21 SkASSERT(__atomic_always_lock_free(sizeof(T), ptr)); 27 SkASSERT(__atomic_always_lock_free(sizeof(T), ptr));
22 return __atomic_store_n(ptr, val, __ATOMIC_RELEASE); 28 return __atomic_store_n(ptr, val, __ATOMIC_RELEASE);
23 } 29 }
24 30
25 #endif//SkBarriers_tsan_DEFINED 31 #endif//SkBarriers_tsan_DEFINED
OLDNEW
« no previous file with comments | « src/ports/SkBarriers_arm.h ('k') | src/ports/SkBarriers_x86.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698