Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2146)

Unified Diff: src/ports/SkBarriers_x86.h

Issue 381143002: Use a consume load in SkLazyPtr. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: compiler barrier Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ports/SkBarriers_tsan.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkBarriers_x86.h
diff --git a/src/ports/SkBarriers_x86.h b/src/ports/SkBarriers_x86.h
index fc57615e04852669c0c625dcd00ecfcdbd51be46..56e2658e9723c95eae2d07cb62406b8c71fc68a0 100644
--- a/src/ports/SkBarriers_x86.h
+++ b/src/ports/SkBarriers_x86.h
@@ -24,6 +24,12 @@ T sk_acquire_load(T* ptr) {
}
template <typename T>
+T sk_consume_load(T* ptr) {
+ // On x86, consume is the same as acquire, i.e. a normal load.
+ return sk_acquire_load(ptr);
+}
+
+template <typename T>
void sk_release_store(T* ptr, T val) {
// On x86, all stores are release stores, so we only need a compiler barrier.
sk_compiler_barrier();
« no previous file with comments | « src/ports/SkBarriers_tsan.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698