Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
index cd8f37cab81086681160409cb7ca8c8d57ada678..b6add513e5c6167e9194e97563d5ebbb52f46191 100644
--- a/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
@@ -41,10 +41,6 @@ class MathCalculatorImpl : public InterfaceImpl<math::Calculator> {
got_connection_ = true;
}
- virtual void OnConnectionError() MOJO_OVERRIDE {
- delete this;
- }
-
virtual void Clear() MOJO_OVERRIDE {
client()->Output(total_);
}
@@ -164,10 +160,6 @@ class ReentrantServiceImpl : public InterfaceImpl<sample::Service> {
got_connection_ = true;
}
- virtual void OnConnectionError() MOJO_OVERRIDE {
- delete this;
- }
-
bool got_connection() const {
return got_connection_;
}

Powered by Google App Engine
This is Rietveld 408576698