mojo/public/cpp/bindings/tests/request_response_unittest.cc - Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/request_response_unittest.cc

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/request_response_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/request_response_unittest.cc b/mojo/public/cpp/bindings/tests/request_response_unittest.cc

index 338d9684dfdf94c440e9ca3a51dffdc472d611e4..a082a0954886eb7017a37d646aed34398cdd5e65 100644

--- a/mojo/public/cpp/bindings/tests/request_response_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/request_response_unittest.cc

@@ -15,10 +15,6 @@ namespace {

class ProviderImpl : public InterfaceImpl<sample::Provider> {

public:

- virtual void OnConnectionError() MOJO_OVERRIDE {

- delete this;

- }

virtual void EchoString(

const String& a,

const Callback<void(String)>& callback) MOJO_OVERRIDE {