Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: mojo/public/cpp/bindings/tests/handle_passing_unittest.cc

Issue 380413003: Mojo: Use InterfaceFactory<Interface> for service registration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc b/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
index 99eddf83410615547d2b3be19a7f8437fb4cf792..e2f51348422dcfce9679034abbddf482d1173e58 100644
--- a/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
@@ -28,10 +28,6 @@ class StringRecorder {
class SampleNamedObjectImpl : public InterfaceImpl<sample::NamedObject> {
public:
- virtual void OnConnectionError() MOJO_OVERRIDE {
- delete this;
- }
-
virtual void SetName(const mojo::String& name) MOJO_OVERRIDE {
name_ = name;
}
@@ -47,10 +43,6 @@ class SampleNamedObjectImpl : public InterfaceImpl<sample::NamedObject> {
class SampleFactoryImpl : public InterfaceImpl<sample::Factory> {
public:
- virtual void OnConnectionError() MOJO_OVERRIDE {
- delete this;
- }
-
virtual void DoStuff(sample::RequestPtr request,
ScopedMessagePipeHandle pipe) MOJO_OVERRIDE {
std::string text1;

Powered by Google App Engine
This is Rietveld 408576698