Improve testing for SDCH.

chrome/browser/profiles/profile_impl_io_data.cc

Index: chrome/browser/profiles/profile_impl_io_data.cc
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index af21c337e34eef02a955aa73bacfbdec58fd2fda..627299547678ab61f2a63a793a188fa4e8f46703 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -496,15 +496,15 @@ void ProfileImplIOData::InitializeInternal(
 
   // Setup the SDCHManager for this profile.
   sdch_manager_.reset(new net::SdchManager);
-  sdch_manager_->set_sdch_fetcher(
-      new net::SdchDictionaryFetcher(
-          sdch_manager_.get(),
-          // SdchDictionaryFetcher takes a reference to the Getter, and
-          // hence implicitly takes ownership.
-          new net::TrivialURLRequestContextGetter(
-              main_context,
-              content::BrowserThread::GetMessageLoopProxyForThread(
-                  content::BrowserThread::IO))));
+  scoped_ptr<net::SdchFetcher> fetcher(new net::SdchDictionaryFetcher(
+      sdch_manager_.get(),
+      // SdchDictionaryFetcher takes a reference to the Getter, and
+      // hence implicitly takes ownership.
+      new net::TrivialURLRequestContextGetter(
+          main_context,
+          content::BrowserThread::GetMessageLoopProxyForThread(
+              content::BrowserThread::IO))));
+  sdch_manager_->set_sdch_fetcher(fetcher.Pass());

[jar (doing other things), 2014/07/31 03:24:34]

nit: perhaps putting results from new at line 503 in a temporary would be a more
readable cleanup?  WDYT?

[Randy Smith (Not in Mondays), 2014/08/11 20:33:25]

See earlier reply.

   main_context->set_sdch_manager(sdch_manager_.get());
 
   // Create a media request context based on the main context, but using a