Improve testing for SDCH.

chrome/browser/profiles/off_the_record_profile_io_data.cc

Index: chrome/browser/profiles/off_the_record_profile_io_data.cc
diff --git a/chrome/browser/profiles/off_the_record_profile_io_data.cc b/chrome/browser/profiles/off_the_record_profile_io_data.cc
index 221eda7ed8a2470b692a5a341b949ef377cd31cd..dff8ff09b1d63e8293fb9f4a58f2a3d4a7b48c85 100644
--- a/chrome/browser/profiles/off_the_record_profile_io_data.cc
+++ b/chrome/browser/profiles/off_the_record_profile_io_data.cc
@@ -255,15 +255,15 @@ void OffTheRecordProfileIOData::InitializeInternal(
 
   // Setup the SDCHManager for this profile.
   sdch_manager_.reset(new net::SdchManager);
-  sdch_manager_->set_sdch_fetcher(
-      new net::SdchDictionaryFetcher(
-          sdch_manager_.get(),
-          // SdchDictionaryFetcher takes a reference to the Getter, and
-          // hence implicitly takes ownership.
-          new net::TrivialURLRequestContextGetter(
-              main_context,
-              content::BrowserThread::GetMessageLoopProxyForThread(
-                  content::BrowserThread::IO))));
+  scoped_ptr<net::SdchFetcher> fetcher(new net::SdchDictionaryFetcher(
+      sdch_manager_.get(),
+      // SdchDictionaryFetcher takes a reference to the Getter, and
+      // hence implicitly takes ownership.
+      new net::TrivialURLRequestContextGetter(
+          main_context,
+          content::BrowserThread::GetMessageLoopProxyForThread(
+              content::BrowserThread::IO))));
+  sdch_manager_->set_sdch_fetcher(fetcher.Pass());

[jar (doing other things), 2014/07/31 03:24:34]

nit: What was the significance of this change? Why put it in a variable first? 
Was the code too long to be readable?  

If so, perhaps the real offender is the argument starting at line 262, and
perhaps that should go in a varible... and then you won't need a multi-line
comment in the *middle* of a function call.  WDYT? 

[Randy Smith (Not in Mondays), 2014/08/11 20:33:25]

The main issue was that consing up a scoped_ptr<> in the middle of a setter
looked like a lot of syntactic sugar to me.  But I've rewritten it and I think
it's a bit better, even if not trivial to understand.  Let me know if the new
version is a problem.

   main_context->set_sdch_manager(sdch_manager_.get());
 
 #if defined(ENABLE_EXTENSIONS)