Improve testing for SDCH.

chrome/browser/profiles/profile_impl_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl_io_data.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 478 matching lines @@
       network_delegate(),
       ftp_factory_.get());
   main_context->set_job_factory(main_job_factory_.get());
 
 #if defined(ENABLE_EXTENSIONS)
   InitializeExtensionsRequestContext(profile_params);
 #endif
 
   // Setup the SDCHManager for this profile.
   sdch_manager_.reset(new net::SdchManager);
-  sdch_manager_->set_sdch_fetcher(
-      new net::SdchDictionaryFetcher(
-          sdch_manager_.get(),
-          // SdchDictionaryFetcher takes a reference to the Getter, and
-          // hence implicitly takes ownership.
-          new net::TrivialURLRequestContextGetter(
-              main_context,
-              content::BrowserThread::GetMessageLoopProxyForThread(
-                  content::BrowserThread::IO))));
+  scoped_ptr<net::SdchFetcher> fetcher(new net::SdchDictionaryFetcher(
+      sdch_manager_.get(),
+      // SdchDictionaryFetcher takes a reference to the Getter, and
+      // hence implicitly takes ownership.
+      new net::TrivialURLRequestContextGetter(
+          main_context,
+          content::BrowserThread::GetMessageLoopProxyForThread(
+              content::BrowserThread::IO))));
+  sdch_manager_->set_sdch_fetcher(fetcher.Pass());

[jar (doing other things), 2014/07/31 03:24:34]

nit: perhaps putting results from new at line 503 in a temporary would be a more
readable cleanup?  WDYT?

[Randy Smith (Not in Mondays), 2014/08/11 20:33:25]

See earlier reply.

   main_context->set_sdch_manager(sdch_manager_.get());
 
   // Create a media request context based on the main context, but using a
   // media cache.  It shares the same job factory as the main context.
   StoragePartitionDescriptor details(profile_path_, false);
   media_request_context_.reset(InitializeMediaRequestContext(main_context,
                                                              details));
 
   if (domain_reliability_monitor_) {
     domain_reliability_monitor_->Init(
@@ skipping 232 matching lines @@
     const base::Closure& completion) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   DCHECK(initialized());
 
   DCHECK(transport_security_state());
   // Completes synchronously.
   transport_security_state()->DeleteAllDynamicDataSince(time);
   DCHECK(http_server_properties_manager_);
   http_server_properties_manager_->Clear(completion);
 }