Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 379743003: [fsp] Remove the create flag from the file opening operation. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Remove the create flag from the file opening operation. This CL removes the create flag, and makes the Open operation fail if a file doesn't exist. This is because a separate event for creating files is coming soon. TEST=unit_tests, browser_tests: *FileSystemProvider*Open*, *FileSystemProvider*ReadFile* BUG=391362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -37 lines) Patch
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 5 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/big_file/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/evil/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@kalman: PTAL at IDL. (More info for this decision at crbug.com). @hirono: PTAL at JS ...
6 years, 5 months ago (2014-07-09 07:44:57 UTC) #1
hirono
lgtm *.js, *.cc, *.h
6 years, 5 months ago (2014-07-09 09:17:36 UTC) #2
not at google - send to devlin
lgtm
6 years, 5 months ago (2014-07-09 13:31:45 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-09 13:52:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/379743003/1
6 years, 5 months ago (2014-07-09 13:53:30 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 14:35:42 UTC) #6
Message was sent while issue was closed.
Change committed as 282033

Powered by Google App Engine
This is Rietveld 408576698