chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h - Issue 379743003: [fsp] Remove the create flag from the file opening operation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

Issue 379743003: [fsp] Remove the create flag from the file opening operation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/provided_file_system.cc ('k') | chrome/common/extensions/api/file_system_provider.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h b/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

index 3f2a2249750f2dae0bf2ccd705a402417657abf7..a43bcc73027a5bb307627bf14017d07d2e6d48c1 100644

--- a/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h

@@ -78,11 +78,10 @@ class ProvidedFileSystemInterface {

const base::FilePath& directory_path,

const fileapi::AsyncFileUtil::ReadDirectoryCallback& callback) = 0;

- // Requests opening a file at |file_path|. If |create| is set to true, it will

- // create a file and return success in case it didn't exist.

+ // Requests opening a file at |file_path|. If the file doesn't exist, then the

+ // operation will fail.

virtual void OpenFile(const base::FilePath& file_path,

OpenFileMode mode,

- bool create,

const OpenFileCallback& callback) = 0;

// Requests closing a file, previously opened with OpenFile() as a file with