chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc - Issue 379743003: [fsp] Remove the create flag from the file opening operation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

Issue 379743003: [fsp] Remove the create flag from the file opening operation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/open_file.cc ('k') | chrome/browser/chromeos/file_system_provider/provided_file_system.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

index 89dde7f00edd71e3bf43f604270a0f0e4031aa37..ef6089538073ce28bf1910daa6e63f7199385e9f 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

@@ -90,7 +90,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, Execute) {

file_system_info_,

base::FilePath::FromUTF8Unsafe(kFilePath),

ProvidedFileSystemInterface::OPEN_FILE_MODE_READ,

- false /* create */,

base::Bind(&CallbackLogger::OnOpenFile,

base::Unretained(&callback_logger)));

open_file.SetDispatchEventImplForTesting(

@@ -128,10 +127,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, Execute) {

extensions::api::file_system_provider::ToString(

extensions::api::file_system_provider::OPEN_FILE_MODE_READ);

EXPECT_EQ(expected_file_open_mode, event_file_open_mode);

- bool event_create;

- EXPECT_TRUE(options->GetBoolean("create", &event_create));

- EXPECT_FALSE(event_create);

}

TEST_F(FileSystemProviderOperationsOpenFileTest, Execute_NoListener) {

@@ -142,7 +137,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, Execute_NoListener) {

file_system_info_,

base::FilePath::FromUTF8Unsafe(kFilePath),

ProvidedFileSystemInterface::OPEN_FILE_MODE_READ,

- false /* create */,

base::Bind(&CallbackLogger::OnOpenFile,

base::Unretained(&callback_logger)));

open_file.SetDispatchEventImplForTesting(

@@ -160,7 +154,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, OnSuccess) {

file_system_info_,

base::FilePath::FromUTF8Unsafe(kFilePath),

ProvidedFileSystemInterface::OPEN_FILE_MODE_READ,

- false /* create */,

base::Bind(&CallbackLogger::OnOpenFile,

base::Unretained(&callback_logger)));

open_file.SetDispatchEventImplForTesting(

@@ -186,7 +179,6 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, OnError) {

file_system_info_,

base::FilePath::FromUTF8Unsafe(kFilePath),

ProvidedFileSystemInterface::OPEN_FILE_MODE_READ,

- false /* create */,

base::Bind(&CallbackLogger::OnOpenFile,

base::Unretained(&callback_logger)));

open_file.SetDispatchEventImplForTesting(