Issue 378583002: Revert "Treat ExecutableAccessorInfo as regular data properties."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 378583002: Revert "Treat ExecutableAccessorInfo as regular data properties." (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Treat ExecutableAccessorInfo as regular data properties." Temporarily revert since blink has some properties like this on the prototype chain where it expects accessorpair-behavior (e.g., window.onload). TBR=dslomov@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22251

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -74 lines)			Patch
M	src/accessors.cc	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	src/ic.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	test/cctest/test-api.cc	View	10 chunks	+32 lines, -47 lines	0 comments	Download
M	test/mjsunit/es7/object-observe.js	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

Committed patchset #1 manually as r22251 (presubmit successful).

6 years, 5 months ago (2014-07-07 16:18:24 UTC) #1

Message was sent while issue was closed.

lgtm (rubberstamp)

Expand Messages | Collapse Messages