Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: src/objects.cc

Issue 378583002: Revert "Treat ExecutableAccessorInfo as regular data properties." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 3d5987c3df73788b90f4939cd5d8faced1f04e6c..f4522db01d9e2fadba75d3e0dc9c4ffe315e1877 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -3094,25 +3094,6 @@ MaybeHandle<Object> JSObject::SetPropertyViaPrototypes(
*done = true;
if (!result.IsReadOnly()) {
Handle<Object> callback_object(result.GetCallbackObject(), isolate);
- // Only store via executable access info setters if the holder is the
- // receiver or on its hidden prototype chain.
- if (callback_object->IsExecutableAccessorInfo()) {
- Handle<JSObject> current = object;
- while (*current != result.holder()) {
- // There is a callbacks holder, so we are guaranteed that all
- // objects in between are JSObjects.
- Handle<JSObject> prototype(
- JSObject::cast(current->GetPrototype()));
- if (!current->IsJSGlobalProxy() &&
- !prototype->map()->is_hidden_prototype()) {
- *done = false;
- break;
- }
- current = prototype;
- }
- // Break out of the switch after breaking out of the loop above.
- if (*current != result.holder()) break;
- }
return SetPropertyWithCallback(object, name, value,
handle(result.holder()),
callback_object, strict_mode);
« no previous file with comments | « src/ic.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698