src/ic.cc - Issue 378583002: Revert "Treat ExecutableAccessorInfo as regular data properties."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 378583002: Revert "Treat ExecutableAccessorInfo as regular data properties." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 6a92719cc210ac22c4bf8747e53e7383f0bfb5e0..60fcdc8a88d0f98ec5d10d4b7f1216e39293cae6 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1206,9 +1206,7 @@ static bool LookupForWrite(Handle<JSObject> receiver,

if (lookup->IsReadOnly() || !lookup->IsCacheable()) return false;

if (lookup->holder() == *receiver) return lookup->CanHoldValue(value);

- if (lookup->IsPropertyCallbacks() &&

- !lookup->GetCallbackObject()->IsExecutableAccessorInfo())

- return true;

+ if (lookup->IsPropertyCallbacks()) return true;

// JSGlobalProxy either stores on the global object in the prototype, or

// goes into the runtime if access checks are needed, so this is always

// safe.

« no previous file with comments | « src/accessors.cc ('k') | src/objects.cc » ('j') | no next file with comments »