Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: chrome/browser/chromeos/events/event_rewriter_unittest.cc

Issue 378503007: Fix some surprising reverse key mappings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase (merges XI2) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.cc ('k') | ui/events/keycodes/keyboard_code_conversion_x.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/events/event_rewriter_unittest.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
index a1777718ebca94efb2730f8c3b3eada72286914e..47e80101c4df06120846b2d40846ed4ded6bc99e 100644
--- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc
+++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
@@ -858,6 +858,16 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapMany) {
{KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
{ui::VKEY_MENU, ui::EF_ALT_DOWN},
{ui::VKEY_CONTROL, ui::EF_CONTROL_DOWN}},
+ // Press Shift+comma. Verify that only the flags are changed.
+ // The X11 portion of the test addresses crbug.com/390263 by verifying
+ // that the X keycode remains that for ',<' and not for 105-key '<>'.
+ {KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
+ {ui::VKEY_OEM_COMMA, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN},
+ {ui::VKEY_OEM_COMMA, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN}},
+ // Press Shift+9. Verify that only the flags are changed.
+ {KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
+ {ui::VKEY_9, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN},
+ {ui::VKEY_9, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN}},
};
for (size_t i = 0; i < arraysize(a2c_tests); ++i) {
« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.cc ('k') | ui/events/keycodes/keyboard_code_conversion_x.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698