Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Side by Side Diff: chrome/browser/chromeos/events/event_rewriter_unittest.cc

Issue 378503007: Fix some surprising reverse key mappings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase (merges XI2) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/events/event_rewriter.h" 5 #include "chrome/browser/chromeos/events/event_rewriter.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "ash/shell.h" 9 #include "ash/shell.h"
10 #include "ash/sticky_keys/sticky_keys_controller.h" 10 #include "ash/sticky_keys/sticky_keys_controller.h"
(...skipping 840 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 // Remap Alt to Control. 851 // Remap Alt to Control.
852 IntegerPrefMember alt; 852 IntegerPrefMember alt;
853 alt.Init(prefs::kLanguageRemapAltKeyTo, &prefs); 853 alt.Init(prefs::kLanguageRemapAltKeyTo, &prefs);
854 alt.SetValue(chromeos::input_method::kControlKey); 854 alt.SetValue(chromeos::input_method::kControlKey);
855 855
856 KeyTestCase a2c_tests[] = { 856 KeyTestCase a2c_tests[] = {
857 // Press left Alt. Confirm the event is now VKEY_CONTROL. 857 // Press left Alt. Confirm the event is now VKEY_CONTROL.
858 {KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED, 858 {KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
859 {ui::VKEY_MENU, ui::EF_ALT_DOWN}, 859 {ui::VKEY_MENU, ui::EF_ALT_DOWN},
860 {ui::VKEY_CONTROL, ui::EF_CONTROL_DOWN}}, 860 {ui::VKEY_CONTROL, ui::EF_CONTROL_DOWN}},
861 // Press Shift+comma. Verify that only the flags are changed.
862 // The X11 portion of the test addresses crbug.com/390263 by verifying
863 // that the X keycode remains that for ',<' and not for 105-key '<>'.
864 {KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
865 {ui::VKEY_OEM_COMMA, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN},
866 {ui::VKEY_OEM_COMMA, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN}},
867 // Press Shift+9. Verify that only the flags are changed.
868 {KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
869 {ui::VKEY_9, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN},
870 {ui::VKEY_9, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN}},
861 }; 871 };
862 872
863 for (size_t i = 0; i < arraysize(a2c_tests); ++i) { 873 for (size_t i = 0; i < arraysize(a2c_tests); ++i) {
864 SCOPED_TRACE(i); 874 SCOPED_TRACE(i);
865 CheckKeyTestCase(&rewriter, a2c_tests[i]); 875 CheckKeyTestCase(&rewriter, a2c_tests[i]);
866 } 876 }
867 877
868 // Remap Control to Search. 878 // Remap Control to Search.
869 IntegerPrefMember control; 879 IntegerPrefMember control;
870 control.Init(prefs::kLanguageRemapControlKeyTo, &prefs); 880 control.Init(prefs::kLanguageRemapControlKeyTo, &prefs);
(...skipping 1510 matching lines...) Expand 10 before | Expand all | Expand 10 after
2381 EXPECT_FALSE(overlay_->GetModifierVisible(ui::EF_ALTGR_DOWN)); 2391 EXPECT_FALSE(overlay_->GetModifierVisible(ui::EF_ALTGR_DOWN));
2382 EXPECT_TRUE(overlay_->GetModifierVisible(ui::EF_MOD3_DOWN)); 2392 EXPECT_TRUE(overlay_->GetModifierVisible(ui::EF_MOD3_DOWN));
2383 2393
2384 // Turn off AltGr and Mod3. 2394 // Turn off AltGr and Mod3.
2385 sticky_keys_controller_->SetModifiersEnabled(false, false); 2395 sticky_keys_controller_->SetModifiersEnabled(false, false);
2386 EXPECT_FALSE(overlay_->GetModifierVisible(ui::EF_ALTGR_DOWN)); 2396 EXPECT_FALSE(overlay_->GetModifierVisible(ui::EF_ALTGR_DOWN));
2387 EXPECT_FALSE(overlay_->GetModifierVisible(ui::EF_MOD3_DOWN)); 2397 EXPECT_FALSE(overlay_->GetModifierVisible(ui::EF_MOD3_DOWN));
2388 } 2398 }
2389 2399
2390 } // namespace chromeos 2400 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.cc ('k') | ui/events/keycodes/keyboard_code_conversion_x.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698