Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2096)

Unified Diff: chrome/browser/chromeos/events/event_rewriter.cc

Issue 378503007: Fix some surprising reverse key mappings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase (merges XI2) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/events/event_rewriter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/events/event_rewriter.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter.cc b/chrome/browser/chromeos/events/event_rewriter.cc
index fdd465ff6897bcd970bbf08d91b758457a58e186..038c5436b021bfc23cad03c6555db0cf59ad4bae 100644
--- a/chrome/browser/chromeos/events/event_rewriter.cc
+++ b/chrome/browser/chromeos/events/event_rewriter.cc
@@ -264,9 +264,14 @@ void EventRewriter::BuildRewrittenKeyEvent(
xkeyevent.xkey = xev->xkey;
// Update native event to match rewritten |ui::Event|.
- xkeyevent.xkey.keycode = XKeysymToKeycode(
- gfx::GetXDisplay(),
- ui::XKeysymForWindowsKeyCode(key_code, flags & ui::EF_SHIFT_DOWN));
+ // The X11 keycode represents a physical key position, so it shouldn't
+ // change unless we have actually changed keys, not just modifiers.
+ // This is one guard against problems like crbug.com/390263.
+ if (key_event.key_code() != key_code) {
+ xkeyevent.xkey.keycode =
+ XKeyCodeForWindowsKeyCode(key_code, flags, gfx::GetXDisplay());
+ }
+
UpdateX11EventMask(flags, &xkeyevent.xkey.state);
ui::KeyEvent x11_key_event(&xkeyevent, false);
rewritten_key_event = new ui::KeyEvent(x11_key_event);
« no previous file with comments | « no previous file | chrome/browser/chromeos/events/event_rewriter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698