Refactor SkPicturePlayback for SkPictureReplacementPlayback

Refactor SkPicturePlayback for SkPictureReplacementPlayback

This CL is intended to maximize code reuse when SkPictureReplacementPlayback is split off.

Committed: https://skia.googlesource.com/skia/+/ec66e6264de5110802c3d9927380d913242c9d5f

[mtklein, 2014-07-09 17:55:01]

https://codereview.chromium.org/378343002/diff/60001/src/core/SkPicturePlayba...
File src/core/SkPicturePlayback.cpp (right):

https://codereview.chromium.org/378343002/diff/60001/src/core/SkPicturePlayba...
src/core/SkPicturePlayback.cpp:238: if
(SkPictureStateTree::Iterator::kDrawComplete == skipTo) {
Is there any chance we could have passed this while adjusting?

Could this method be implemented in terms of StepIterator?

[robertphillips, 2014-07-09 18:12:39]

https://codereview.chromium.org/378343002/diff/60001/src/core/SkPicturePlayba...
File src/core/SkPicturePlayback.cpp (right):

https://codereview.chromium.org/378343002/diff/60001/src/core/SkPicturePlayba...
src/core/SkPicturePlayback.cpp:238: if
(SkPictureStateTree::Iterator::kDrawComplete == skipTo) {
On 2014/07/09 17:55:01, mtklein wrote:
> Is there any chance we could have passed this while adjusting?
> 
> Could this method be implemented in terms of StepIterator?

skipTo will never be kDrawComplete on entry (I'll add an assert).

We could replace all instances of StepIterator(i, r) with SkipIterTo(i, r, 0)
but that might be a bit confusing.

[mtklein, 2014-07-09 18:22:05]

> skipTo will never be kDrawComplete on entry (I'll add an assert).

SGTM

> We could replace all instances of StepIterator(i, r) with SkipIterTo(i, r, 0)
> but that might be a bit confusing.

Was thinking more that SkipIterTo looks like it could be implemented as a loop
of StepIterator.  Is that wrong?

[robertphillips, 2014-07-09 19:31:50]

PTAL - I have moved StepIterator above SkipIterTo

[mtklein, 2014-07-09 19:36:09]

lgtm

[robertphillips, 2014-07-09 19:38:00]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-07-09 19:38:45]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/378343002/1...

[commit-bot: I haz the power, 2014-07-09 20:00:11]

Change committed as ec66e6264de5110802c3d9927380d913242c9d5f