Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 378283002: Revert 281999 "Revert 281831 "Fix nacl_integration to run 32bit ..." (Closed)

Created:
6 years, 5 months ago by kaliamoorthi
Modified:
6 years, 5 months ago
Reviewers:
kaliamoorthi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 281999 "Revert 281831 "Fix nacl_integration to run 32bit ..." > Revert 281831 "Fix nacl_integration to run 32bit tests with 32bi..." > > > Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel. > > > > detect_host_arch.py already knows how to figure this out, so reuse it. > > (It could probably be used in the darwin and maybe even in the windows > > branch too.) > > > > BUG=368384 > > TEST=nacl_integration on http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/ goes green > > TBR=mseaborn@chromium.org > > > > Review URL: https://codereview.chromium.org/373253002 > > Suspect this is causing the failure http://build.chromium.org/p/chromium.win/builders/NaCl%20Tests%20%28x86-64%29/builds/13394 > > TBR=thakis@chromium.org > > Review URL: https://codereview.chromium.org/374383002 Reverting the revert since it doesn't seem to cause the problem TBR=kaliamoorthi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M trunk/src/build/detect_host_arch.py View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kaliamoorthi
6 years, 5 months ago (2014-07-09 12:06:17 UTC) #1
kaliamoorthi
6 years, 5 months ago (2014-07-09 12:06:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r282008 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698