Issue 373253002: Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 373253002: Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
Mark Seaborn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel. detect_host_arch.py already knows how to figure this out, so reuse it. (It could probably be used in the darwin and maybe even in the windows branch too.) BUG=368384 TEST=nacl_integration on http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/ goes green TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281831

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
	M	build/detect_host_arch.py	View		2 chunks	+8 lines, -8 lines	0 comments	Download
	M	chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py	View		2 chunks	+6 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Nico

Committed patchset #1 manually as r281831 (presubmit successful).

6 years, 5 months ago (2014-07-08 21:11:54 UTC) #2

Message was sent while issue was closed.

LGTM