Issue 374383002: Revert 281831 "Fix nacl_integration to run 32bit tests with 32bi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 374383002: Revert 281831 "Fix nacl_integration to run 32bit tests with 32bi..." (Closed)

Created:
6 years, 5 months ago by kaliamoorthi

Modified:
6 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 281831 "Fix nacl_integration to run 32bit tests with 32bi..." > Fix nacl_integration to run 32bit tests with 32bit userland and 64bit kernel. > > detect_host_arch.py already knows how to figure this out, so reuse it. > (It could probably be used in the darwin and maybe even in the windows > branch too.) > > BUG=368384 > TEST=nacl_integration on http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/ goes green > TBR=mseaborn@chromium.org > > Review URL: https://codereview.chromium.org/373253002 Suspect this is causing the failure http://build.chromium.org/p/chromium.win/builders/NaCl%20Tests%20%28x86-64%29/builds/13394 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281999

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	trunk/src/build/detect_host_arch.py	View		2 chunks	+8 lines, -8 lines	0 comments	Download
	M	trunk/src/chrome/test/nacl_test_injection/buildbot_chrome_nacl_stage.py	View		2 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

kaliamoorthi

Committed patchset #1 manually as r281999 (tree was closed).

6 years, 5 months ago (2014-07-09 10:34:04 UTC) #2

Nico

6 years, 5 months ago (2014-07-09 15:54:33 UTC) #3

Message was sent while issue was closed.

The change you reverted was linux-only, so it probably didn't cause a problem on
the win bots. Thanks for reverting your revert!