Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 378253002: Fix translate namespace (Closed)

Created:
6 years, 5 months ago by nshaik
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, jam, yusukes+watch_chromium.org, zea+watch_chromium.org, yukishiino+watch_chromium.org, benquan, haitaol+watch_chromium.org, browser-components-watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, dbeam+watch-options_chromium.org, Dane Wallinga, dyu1, chromium-apps-reviews_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix translate namespace Translate is turned into a component, classes and functions have to be moved to the translate:: namespace. BUG=331782 TEST=components_unittests:unit_tests --gtest_filter=Translate* TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284742

Patch Set 1 #

Patch Set 2 : #

Total comments: 22

Patch Set 3 : Address review comments #

Patch Set 4 : Rebasing the patchset #

Patch Set 5 : Rebase patchset #

Patch Set 6 : Reverting the change to remove TranslateBrowserMetrics #

Patch Set 7 : Removing unnecessary specialization #

Patch Set 8 : Fixing linux build errors #

Patch Set 9 : Fixing compilation errors #

Patch Set 10 : Fixing build errors on linux #

Patch Set 11 : Fixing android build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+739 lines, -450 lines) Patch
M chrome/browser/autofill/autofill_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/translate/chrome_translate_client.h View 4 chunks +25 lines, -18 lines 0 comments Download
M chrome/browser/translate/chrome_translate_client.cc View 1 2 3 12 chunks +45 lines, -35 lines 0 comments Download
M chrome/browser/translate/translate_accept_languages_factory.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_accept_languages_factory.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_browsertest.cc View 10 chunks +19 lines, -12 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 1 2 3 43 chunks +102 lines, -78 lines 0 comments Download
M chrome/browser/translate/translate_service.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.h View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_content_translate_driver_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_content_translate_driver_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/after_translate_infobar_controller.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/before_translate_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm View 9 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 6 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_message_infobar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/translate/translate_bubble_factory.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model_impl.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model_impl.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.h View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 2 3 4 5 6 7 5 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc View 1 2 3 4 5 6 7 8 9 6 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.h View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc View 1 2 3 8 chunks +23 lines, -21 lines 0 comments Download
M chrome/renderer/translate/translate_helper.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 1 2 3 7 chunks +17 lines, -10 lines 0 comments Download
M chrome/renderer/translate/translate_helper_browsertest.cc View 7 chunks +15 lines, -14 lines 0 comments Download
M chrome/renderer/translate/translate_script_browsertest.cc View 7 chunks +13 lines, -12 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +4 lines, -3 lines 0 comments Download
M components/infobars/core/infobar_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M components/infobars/core/infobar_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/translate/content/browser/content_translate_driver.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/content/browser/content_translate_driver.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/content/common/translate_messages.h View 2 chunks +11 lines, -9 lines 0 comments Download
M components/translate/core/browser/language_state.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/language_state.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/language_state_unittest.cc View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/options_menu_model.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/options_menu_model.cc View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/page_translated_details.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_accept_languages.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_accept_languages.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_browser_metrics.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_browser_metrics.cc View 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_browser_metrics_unittest.cc View 1 2 3 4 5 3 chunks +79 lines, -58 lines 0 comments Download
M components/translate/core/browser/translate_client.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M components/translate/core/browser/translate_download_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_download_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_driver.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_error_details.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_event_details.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_event_details.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_infobar_delegate.h View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M components/translate/core/browser/translate_infobar_delegate.cc View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_language_list.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M components/translate/core/browser/translate_language_list.cc View 1 2 3 4 5 6 3 chunks +6 lines, -2 lines 0 comments Download
M components/translate/core/browser/translate_manager.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_manager.cc View 1 2 3 4 5 3 chunks +6 lines, -2 lines 0 comments Download
M components/translate/core/browser/translate_prefs.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M components/translate/core/browser/translate_prefs.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_prefs_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_script.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_script.cc View 1 2 6 3 chunks +6 lines, -4 lines 0 comments Download
M components/translate/core/browser/translate_script_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_ui_delegate.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_ui_delegate.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_url_fetcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_url_fetcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/browser/translate_url_util.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/translate/core/browser/translate_url_util.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M components/translate/core/common/language_detection_details.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/common/language_detection_details.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/translate/core/common/translate_errors.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/translate/core/common/translate_metrics_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 50 (0 generated)
nshaik
+droger for: chrome/browser/translate/chrome_translate_client.cc chrome/browser/translate/chrome_translate_client.h chrome/browser/translate/translate_accept_languages_factory.cc chrome/browser/translate/translate_accept_languages_factory.h chrome/browser/translate/translate_browsertest.cc chrome/browser/translate/translate_manager_browsertest.cc chrome/browser/translate/translate_manager_render_view_host_unittest.cc chrome/browser/translate/translate_service.cc chrome/renderer/translate/translate_helper.cc chrome/renderer/translate/translate_helper.h chrome/renderer/translate/translate_helper_browsertest.cc chrome/renderer/translate/translate_script_browsertest.cc components/translate/content/browser/content_translate_driver.cc ...
6 years, 5 months ago (2014-07-09 07:33:00 UTC) #1
nshaik
+droger for: chrome/browser/translate/chrome_translate_client.cc chrome/browser/translate/chrome_translate_client.h chrome/browser/translate/translate_accept_languages_factory.cc chrome/browser/translate/translate_accept_languages_factory.h chrome/browser/translate/translate_browsertest.cc chrome/browser/translate/translate_manager_browsertest.cc chrome/browser/translate/translate_manager_render_view_host_unittest.cc chrome/browser/translate/translate_service.cc chrome/renderer/translate/translate_helper.cc chrome/renderer/translate/translate_helper.h chrome/renderer/translate/translate_helper_browsertest.cc chrome/renderer/translate/translate_script_browsertest.cc components/translate/content/browser/content_translate_driver.cc ...
6 years, 5 months ago (2014-07-09 07:33:04 UTC) #2
nshaik
+droger for: chrome/browser/translate/chrome_translate_client.cc chrome/browser/translate/chrome_translate_client.h chrome/browser/translate/translate_accept_languages_factory.cc chrome/browser/translate/translate_accept_languages_factory.h chrome/browser/translate/translate_browsertest.cc chrome/browser/translate/translate_manager_browsertest.cc chrome/browser/translate/translate_manager_render_view_host_unittest.cc chrome/browser/translate/translate_service.cc chrome/renderer/translate/translate_helper.cc chrome/renderer/translate/translate_helper.h chrome/renderer/translate/translate_helper_browsertest.cc chrome/renderer/translate/translate_script_browsertest.cc components/translate/content/browser/content_translate_driver.cc ...
6 years, 5 months ago (2014-07-09 07:33:09 UTC) #3
blundell
-sky, -blundell as reviewers droger@ can review this and then you can TBR a //chrome ...
6 years, 5 months ago (2014-07-09 07:51:00 UTC) #4
droger
Thanks for doing this work. I only have minor comments. https://codereview.chromium.org/378253002/diff/10094/chrome/browser/ui/cocoa/browser_window_controller.mm File chrome/browser/ui/cocoa/browser_window_controller.mm (right): https://codereview.chromium.org/378253002/diff/10094/chrome/browser/ui/cocoa/browser_window_controller.mm#newcode1755 ...
6 years, 5 months ago (2014-07-09 07:52:44 UTC) #5
nshaik
Please review. https://codereview.chromium.org/378253002/diff/10094/chrome/browser/ui/cocoa/browser_window_controller.mm File chrome/browser/ui/cocoa/browser_window_controller.mm (right): https://codereview.chromium.org/378253002/diff/10094/chrome/browser/ui/cocoa/browser_window_controller.mm#newcode1755 chrome/browser/ui/cocoa/browser_window_controller.mm:1755: errorType { On 2014/07/09 07:52:43, droger wrote: ...
6 years, 5 months ago (2014-07-09 08:56:52 UTC) #6
droger
lgtm
6 years, 5 months ago (2014-07-09 09:47:00 UTC) #7
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-09 15:34:19 UTC) #8
nshaik
The CQ bit was unchecked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-09 15:34:50 UTC) #9
nshaik
On 2014/07/09 09:47:00, droger wrote: > lgtm droger@ does some one need to TBR this ...
6 years, 5 months ago (2014-07-09 17:44:13 UTC) #10
droger
On 2014/07/09 17:44:13, naiem.shaik wrote: > On 2014/07/09 09:47:00, droger wrote: > > lgtm > ...
6 years, 5 months ago (2014-07-09 18:49:47 UTC) #11
nshaik
TBR=thakis
6 years, 5 months ago (2014-07-09 19:55:45 UTC) #12
nshaik
On 2014/07/09 19:55:45, naiem.shaik wrote: > TBR=thakis thakis@ can you please TBR the changes. Thanks, ...
6 years, 5 months ago (2014-07-10 02:09:52 UTC) #13
blundell
On 2014/07/10 02:09:52, naiem.shaik wrote: > On 2014/07/09 19:55:45, naiem.shaik wrote: > > TBR=thakis > ...
6 years, 5 months ago (2014-07-10 07:56:28 UTC) #14
nshaik
TBR=thakis for: //chrome outside of //chrome/browser/translate).
6 years, 5 months ago (2014-07-10 17:46:18 UTC) #15
blundell
Thanks, you should be good to try to commit now, although it looks like the ...
6 years, 5 months ago (2014-07-11 06:32:35 UTC) #16
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-13 22:20:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/378253002/30001
6 years, 5 months ago (2014-07-13 22:21:05 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-13 22:33:08 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-13 22:34:44 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/28032)
6 years, 5 months ago (2014-07-13 22:34:46 UTC) #21
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-19 07:53:05 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/378253002/70001
6 years, 5 months ago (2014-07-19 07:53:54 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 09:40:01 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 09:43:24 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/171881)
6 years, 5 months ago (2014-07-19 09:43:26 UTC) #26
nshaik
@droger: For the file components/translate/core/browser/translate_browser_metrics.h I ran into an issue while removing namespace translate_browser_metrics. After ...
6 years, 5 months ago (2014-07-21 06:57:21 UTC) #27
droger
On 2014/07/21 06:57:21, naiem.shaik wrote: > @droger: > For the file components/translate/core/browser/translate_browser_metrics.h > I ran ...
6 years, 5 months ago (2014-07-21 17:06:37 UTC) #28
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 01:31:23 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/378253002/100094
6 years, 5 months ago (2014-07-22 01:34:07 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 04:51:06 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 04:59:01 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/208955)
6 years, 5 months ago (2014-07-22 04:59:04 UTC) #33
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 05:41:56 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/378253002/120001
6 years, 5 months ago (2014-07-22 05:42:25 UTC) #35
nshaik
The CQ bit was unchecked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 06:06:27 UTC) #36
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 06:24:43 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/378253002/140001
6 years, 5 months ago (2014-07-22 06:25:23 UTC) #38
nshaik
The CQ bit was unchecked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 06:43:48 UTC) #39
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 07:04:01 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/378253002/160001
6 years, 5 months ago (2014-07-22 07:04:41 UTC) #41
nshaik
The CQ bit was unchecked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 07:22:34 UTC) #42
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 07:28:23 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/378253002/180001
6 years, 5 months ago (2014-07-22 07:28:34 UTC) #44
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 09:24:15 UTC) #45
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 11:01:10 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/33002)
6 years, 5 months ago (2014-07-22 11:01:12 UTC) #47
nshaik
The CQ bit was checked by naiem.shaik@gmail.com
6 years, 5 months ago (2014-07-22 16:58:02 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/naiem.shaik@gmail.com/378253002/180001
6 years, 5 months ago (2014-07-22 16:59:32 UTC) #49
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 19:06:58 UTC) #50
Message was sent while issue was closed. 
Change committed as 284742

Powered by Google App Engine
This is Rietveld 408576698