chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc - Issue 378253002: Fix translate namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

Issue 378253002: Fix translate namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing android build errors Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/translate/translate_bubble_view.cc ('k') | chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

index aee42f6595b103f9fb461216ec0873ce29d24ba0..0f5ba472350572722fad9ea1f408baf39125e77d 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc

@@ -45,7 +45,7 @@ IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,

browser()->tab_strip_model()->GetActiveWebContents();

content::Source<content::WebContents> source(current_web_contents);

ui_test_utils::WindowedNotificationObserverWithDetails<

- LanguageDetectionDetails>

+ translate::LanguageDetectionDetails>

fr_language_detected_signal(chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED,

source);

GURL french_url = ui_test_utils::GetTestUrl(

@@ -68,7 +68,7 @@ IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,

browser()->tab_strip_model()->GetActiveWebContents();

content::Source<content::WebContents> source(current_web_contents);

ui_test_utils::WindowedNotificationObserverWithDetails<

- LanguageDetectionDetails>

+ translate::LanguageDetectionDetails>

fr_language_detected_signal(chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED,

source);

GURL french_url = ui_test_utils::GetTestUrl(

@@ -102,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,

browser()->tab_strip_model()->GetWebContentsAt(french_index);

content::Source<content::WebContents> source(web_contents);

ui_test_utils::WindowedNotificationObserverWithDetails<

- LanguageDetectionDetails>

+ translate::LanguageDetectionDetails>

fr_language_detected_signal(chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED,

source);

fr_language_detected_signal.Wait();