AppWindowContents: Clean up unnecessary SuspendRenderViewHost.

chrome/browser/extensions/api/app_window/app_window_api.cc

Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index 199fbf4b9afcf5c70f65f9c120e15ee1d71df112..9735b677d025477e1aad306d7a062f182cba3d24 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -278,9 +278,6 @@ bool AppWindowCreateFunction::RunAsync() {
     }
   }
 
-  create_params.creator_process_id =
-      render_view_host_->GetProcess()->GetID();
-
   AppWindow* app_window = apps::AppsClient::Get()->CreateAppWindow(
       browser_context(), GetExtension());
   app_window->Init(
@@ -292,7 +289,8 @@ bool AppWindowCreateFunction::RunAsync() {
   content::RenderViewHost* created_view =
       app_window->web_contents()->GetRenderViewHost();
   int view_id = MSG_ROUTING_NONE;
-  if (create_params.creator_process_id == created_view->GetProcess()->GetID())
+  if (render_view_host_->GetProcess()->GetID() ==
+      created_view->GetProcess()->GetID())

[not at google - send to devlin, 2014/07/09 13:48:50]

nit: body should have {} since condition is 2 lines.

not-nit: relating to previous comment, seems like this should be a DCHECK_EQ not
an if.

btw this is the same check as up on line 199, maybe that should be the same.

[Matt Giuca, 2014/07/10 03:37:06]

I'm not sure about the DCHECK vs if. I'll leave it up to the other reviewers to
decide.

[scheib, 2014/07/10 16:53:11]

An if or a CHECK I think --- if we just use a DCHECK then non equal IDs will
change the routing, which could be a security issue, for non-trivial to
understand code.  I favor the CHECK, see if it works, in which case we'll have
more certainty of the code behavior.

[not at google - send to devlin, 2014/07/10 17:03:10]

yeah, I think an if is fine.

[Matt Giuca, 2014/07/11 00:15:49]

So I'll leave this as-is.

     view_id = created_view->GetRoutingID();
 
   base::DictionaryValue* result = new base::DictionaryValue;